Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getComponent #2079

Closed

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 20, 2024

Remove outdated getComponent method

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.19%. Comparing base (0501dfe) to head (5228b84).
Report is 10 commits behind head on development.

Files with missing lines Patch % Lines
src/Views/Traits/Core/HasFooter.php 0.00% 1 Missing ⚠️
src/Views/Traits/Core/HasSecondaryHeader.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2079      +/-   ##
=================================================
+ Coverage          88.13%   88.19%   +0.06%     
+ Complexity          1945     1944       -1     
=================================================
  Files                186      186              
  Lines               4441     4439       -2     
=================================================
+ Hits                3914     3915       +1     
+ Misses               527      524       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lrljoe lrljoe closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant