Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development to Master (v3.5.4) #2073

Merged
merged 149 commits into from
Nov 21, 2024
Merged

Development to Master (v3.5.4) #2073

merged 149 commits into from
Nov 21, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 20, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 30 commits August 16, 2024 07:59
* Unlock properties locked in error

---------

Co-authored-by: lrljoe <[email protected]>
* Add additional dispatch

* Add FilterApplied Event

* Add Filter Event Dispatch Tests

---------

Co-authored-by: lrljoe <[email protected]>
* Make ActionButtons An Optional Feature in Beta


---------

Co-authored-by: lrljoe <[email protected]>
* Adjust Methods - useComputedProperties

* Adjust ActionTest
* Add setIconLeft/setIconRight

* Fix styling

* Adjust Test

* Adjust ActionTest

---------

Co-authored-by: lrljoe <[email protected]>
* Adjust Action Button Icon Margin

* Adjust ChangeLog
* Change Order of "Getting Started" section

* Change to "UsersTable"
* Add a "Recommended" approach

* Add blurb to Recommended
* Add displayActionsInToolbar and actionsPosition

* Add docs and tests for setActionsInToolbar

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
lrljoe and others added 21 commits November 10, 2024 06:37
* Add updatedPerPageTest

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Update phpdoc for boot

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add test for No Columns

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add Simple updatedSearch tests

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add test for FilterApplied being dispatched

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add test for ColumnsSelected Event dispatch


* Apply Separate Tests

---------

Co-authored-by: lrljoe <[email protected]>
* FixSetDefaultPerPage

* Update getDefaultPerPage to respect getPerPageAccepted

* Fix missing )

* Fix styling

* Add test fix

* Add final tests

---------

Co-authored-by: lrljoe <[email protected]>
* Fix BooleanColumn unexpected truthy behaviour

* Support previous iteration
* Add option to use json or PHP localisation files (interim fixes)

* Fix styling

* Typehinting Fixes

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 79.06977% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.15%. Comparing base (8b3e3cf) to head (6e51ab1).
Report is 106 commits behind head on master.

Files with missing lines Patch % Lines
src/LaravelLivewireTablesServiceProvider.php 50.00% 6 Missing ⚠️
src/Views/Traits/Columns/IsSortable.php 0.00% 2 Missing ⚠️
config/livewire-tables.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2073      +/-   ##
============================================
+ Coverage     86.55%   88.15%   +1.60%     
- Complexity     1351     1945     +594     
============================================
  Files           124      186      +62     
  Lines          3198     4441    +1243     
============================================
+ Hits           2768     3915    +1147     
- Misses          430      526      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

lrljoe and others added 7 commits November 20, 2024 02:42
* Add ColorColumnTests

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add Attributes Check For ViewComponentColumn

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* test_can_validate_null_boolean_filter_value

* Fix styling

* Add IsEmpty Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe lrljoe merged commit 9bc0401 into master Nov 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants