Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.5.2 - Migrate Localisations back to PHP Files from JSON #2040

Merged
merged 119 commits into from
Nov 10, 2024
Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 10, 2024

This reverts the package to using PHP files rather than JSON files for localisations.

This is due to conflicts with other packages resulting in unexpected behaviour.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 30 commits August 16, 2024 07:59
* Unlock properties locked in error

---------

Co-authored-by: lrljoe <[email protected]>
* Add additional dispatch

* Add FilterApplied Event

* Add Filter Event Dispatch Tests

---------

Co-authored-by: lrljoe <[email protected]>
* Make ActionButtons An Optional Feature in Beta


---------

Co-authored-by: lrljoe <[email protected]>
* Adjust Methods - useComputedProperties

* Adjust ActionTest
* Add setIconLeft/setIconRight

* Fix styling

* Adjust Test

* Adjust ActionTest

---------

Co-authored-by: lrljoe <[email protected]>
* Adjust Action Button Icon Margin

* Adjust ChangeLog
* Change Order of "Getting Started" section

* Change to "UsersTable"
* Add a "Recommended" approach

* Add blurb to Recommended
* Add displayActionsInToolbar and actionsPosition

* Add docs and tests for setActionsInToolbar

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
lrljoe and others added 28 commits October 1, 2024 04:37
* Adding Tools/Toolbar Enable Tests

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add Norwegian Bokmål nb.json

GTP translated verified by human

* Added Albanian sq.json

GTP translated, not verified by human
* Clean localization files by adding missing keys (in english) and re-ordering a few misplaced ones

* Update localization for french

* Update localization for spanish

* Update localization for italian

* Update localization for german

* Revert "Clean localization files by adding missing keys (in english) and re-ordering a few misplaced ones"

This reverts commit d440bd2.
* Move LoadingPlaceholderStyling into new method

* Add "Loading" default translation

* Move Placeholder Blade Config backwards

* Adjustments to Placeholder Attributes

* Tweak Row Behaviour

---------

Co-authored-by: lrljoe <[email protected]>
Adjusting Documentation -> The Livewire column type doesn't have the `HasTitleCallback` trait, so you can't use `->title()`.
* Add Value to BooleanColumn view

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Improve Workflow Caches

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add customisation for QueryString specific to Filters

* Move all QueryString Filter Code to HasQueryStringForFilter


---------

Co-authored-by: lrljoe <[email protected]>
* Fix bug with FilterQueryString

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* AddSearchQueryString

* Add tests for hasQueryStringAliasFor...

* Additional Tests For SearchQueryString

* Move Livewire to Visuals section

* Simplify the queryString methods

* Add hasQueryStringAliasForSearch test

* PCOV Runs as PHPUnit not ParaTest

* Remove PCOV From Workflows Where Not Used

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add QueryStringForSort

* Adjust for SortQueryString

* Tests

* Tweaks to Configure Approach


---------

Co-authored-by: lrljoe <[email protected]>
* Initial Commit

* Add blade for Livewire Component Array Filter - not live

---------

Co-authored-by: lrljoe <[email protected]>
* Adds Swedish translations

* Update weird translation strings

I was stressed (:

* Update sv.json
* Adjust Number Filter - Convert Value to Float/int If All Digits

---------

Co-authored-by: lrljoe <[email protected]>
* Fixes for Filter Pills - Ensure Invalid Options Are Removed

---------

Co-authored-by: lrljoe <[email protected]>
* Initial Movement of Tests into Directories

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Fix localisations migrate to php files (#91)

* Initial Fixes

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Adjust test suites

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe lrljoe merged commit 05f664d into master Nov 10, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants