Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Localisations To PHP vs JSON #2038

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 10, 2024

This:

  1. Reverts back to using PHP files for localisation
  2. Splits tests so that Unit tests live in their own directory, and own test suite
  3. Creates some basic Localisation tests in their own directory, and test suite.

This is to assist with:

  1. Bugs associated with JSON localisation
  2. Improving Localisation coverage

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 3 commits November 10, 2024 02:14
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.73%. Comparing base (0c8ec45) to head (1649677).
Report is 154 commits behind head on development.

Files with missing lines Patch % Lines
src/Views/Traits/Columns/IsSortable.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2038      +/-   ##
=================================================
+ Coverage          87.30%   87.73%   +0.42%     
- Complexity          1672     1934     +262     
=================================================
  Files                150      184      +34     
  Lines               3891     4426     +535     
=================================================
+ Hits                3397     3883     +486     
- Misses               494      543      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 90355f8 into rappasoft:development Nov 10, 2024
9 checks passed
@lrljoe lrljoe mentioned this pull request Nov 10, 2024
lrljoe added a commit that referenced this pull request Nov 10, 2024
## [v3.5.2] - 2024-11-09
## Bug Fixes
- Migrate Localisation back to PHP Files from JSON by @lrljoe in #2038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant