Fix bug #1997 - Found the issue elsewhere also, so I fixed them too.

[mrl22]

This pull request is to fix bug #1997 .

I have found this issue in multiple places where there is incorrect brackets in conjunction with coalescing operator (??).

Example:

$input1 = false;
$input2 = true;
return ($input1 ?? true || $input2 ?? true); // Will always return value of $input1 unless null

Fixed:

return (($input1 ?? true) || $input2 ?? true); // Will only return true if either (or both) $input1 or $input2 are null or true.

[lrljoe]

Thanks for the contribution, very helpful :)

However -please base your PR on the "development" branch, I've set the tests to run, but please rebase to get this merged in.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.19%. Comparing base (0c8ec45) to head (1ed0c5d).
Report is 139 commits behind head on development.

Additional details and impacted files

@@                Coverage Diff                @@
##             development    #2004      +/-   ##
=================================================
+ Coverage          87.30%   88.19%   +0.88%     
- Complexity          1672     1855     +183     
=================================================
  Files                150      174      +24     
  Lines               3891     4285     +394     
=================================================
+ Hits                3397     3779     +382     
- Misses               494      506      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mrl22]

Apologies, I am not very familiar with PR’s, I will read up.

[lrljoe]

Apologies, I am not very familiar with PR’s, I will read up.

So I rebased your branch, and you can see where it's a bit confusing due to other pending changes.

In your fork, create a new branch, and base it on the "development" branch.

Then apply your changes, and raise a new PR.

[mrl22]

Thank you, leave it with me :)

[lrljoe]

Thank you, leave it with me :)

I've replicated your changes I think, please check out this PR to ensure I've mirrored them:
#2016

In your fork, instead of clicking "New Branch", go here:
https://github.com/mrl22/laravel-livewire-tables/branches

Click "New Branch", and then select the "rappasoft/laravel-livewire-tables" repo, then select "development" as the repository.

This will ensure that you are working with the "development" branch, which often has fixes/changes in it that aren't in "master" yet.