-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading Placeholder Adjustments #1987
Merged
lrljoe
merged 9 commits into
rappasoft:development
from
LowerRockLabs:AdjustLoadingPlaceholderBlade
Oct 20, 2024
Merged
Loading Placeholder Adjustments #1987
lrljoe
merged 9 commits into
rappasoft:development
from
LowerRockLabs:AdjustLoadingPlaceholderBlade
Oct 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1987 +/- ##
=================================================
+ Coverage 87.30% 88.29% +0.98%
- Complexity 1672 1857 +185
=================================================
Files 150 176 +26
Lines 3891 4287 +396
=================================================
+ Hits 3397 3785 +388
- Misses 494 502 +8 ☔ View full report in Codecov by Sentry. |
lrljoe
added a commit
that referenced
this pull request
Nov 6, 2024
* Add explanation of setRefreshMethod (#1857) * Unlocking Entangled Items (#1859) * Unlock properties locked in error --------- Co-authored-by: lrljoe <[email protected]> * Add dispatch on updated filter components (#1861) * Add additional dispatch * Add FilterApplied Event * Add Filter Event Dispatch Tests --------- Co-authored-by: lrljoe <[email protected]> * v3.4.8 * Fix superfluous bulk actions tr < (#1868) * Default useComputedProperties to False (#1869) * Update ChangeLog * Add Action Buttons (#1864) * Make ActionButtons An Optional Feature in Beta --------- Co-authored-by: lrljoe <[email protected]> * FixDateRangeFilter (#1872) * Adjust Methods - useComputedProperties (#1873) * Adjust Methods - useComputedProperties * Adjust ActionTest * Update ChangeLog * AllowDeleteDateRangeFilter (#1875) * Fix ChangeLog * Update Docs (#1876) * Update ChangeLog - Add Docs Update * Add setIconLeft/setIconRight (#1877) * Add setIconLeft/setIconRight * Fix styling * Adjust Test * Adjust ActionTest --------- Co-authored-by: lrljoe <[email protected]> * Adjust ChangeLog * Adjust Action Button Icon Margin (#1880) * Adjust Action Button Icon Margin * Adjust ChangeLog * Change Order of "Getting Started" section (#1883) * Change Order of "Getting Started" section * Change to "UsersTable" * Add Button with No Icon (#1887) * Add a "Recommended" approach (#1886) * Add a "Recommended" approach * Add blurb to Recommended * v3.4.13 * Set actions position (#1889) * Add displayActionsInToolbar and actionsPosition * Add docs and tests for setActionsInToolbar * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Update ChangeLog * Doc Type Fixes (#1891) * Update NumberFilter and TypeHints * Update DateFilter/DateTimeFilter and ConfigurableAreasHelpers for typehints and array key exists * Add Float Test for NumberFilter * Add ColorColumn View Test * Adjust ColumnSelectConfigurationTest --------- Co-authored-by: lrljoe <[email protected]> * BooleanColumn - Toggleable Callback (#1892) * Add Docs, Code for Toggleable Columns * Add Confirmation Option * Tweak Blade - Standardise * Add Tests for Toggleable --------- Co-authored-by: lrljoe <[email protected]> * Update ChangeLog * Enable/Disable Tools/Toolbar (#1896) * Customised Toolbar Approach --------- Co-authored-by: lrljoe <[email protected]> * Use Computed Properties By Default (#1898) * Fix has actions (#1901) * Fix Action Repetitive Calling * Fix validActionsCount --------- Co-authored-by: lrljoe <[email protected]> * Add icon column (#1902) * Initial Commit - Awaiting Docs & Tests * Tweak to IconColumn label behaviour * Adding IconColumn documentation * Add Additional Tests - Replace Test Database * Add Visuals Test for IconColumn * Add Icon Columns to Other Column Types * Undo FrontendAssetsTest Changes --------- Co-authored-by: lrljoe <[email protected]> * Add Baseline - Convert phpstan.neon to tabs (#1903) * Update ChangeLog * Save filter selection to session (BETA) (#1910) * Initial Commit * Fix styling * Initial Commit * Fix styling * Fix nullable return * Add Initial Tests - Remove Non-Required Method * Fix styling * Swap methods * Add default docs * Remove errant note * Adjust docs * Adjust Docs for storeFiltersInSessionEnabled --------- Co-authored-by: lrljoe <[email protected]> * Add hide table option (#1914) * Initial Commit * Fix styling * Further adjustments * Fix styling * Improve Tests - Extend PetsTable * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add column select session methods (#1913) * Initial Commit * Fix styling * Minor Tweaks * Fix styling * Fix Tests * Add Tests for StoredColumnSelect * Fix styling * Add Missing Tests * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Use Core HasTheme Methods (#1915) * Centralise Theme Methods * Fix styling * Fix for broken tests * Fix styling * Remove persisted computed properties --------- Co-authored-by: lrljoe <[email protected]> * Use Core Attribute Bag (#1916) * Initial Commit * Fix styling * Add Missing Test * Fix styling * Adjustments * Fix styling * Adjust Test * Fix styling * Fix Sorting Visual Test --------- Co-authored-by: lrljoe <[email protected]> * Fix ChangeLog * Add Polish translation by @meavric (#1925) * Add Polish translation by @meavric * Update ChangeLog to reflect translation * Add Vertical Scrolling Example (#1926) * Adjusting contributing * Fix missing variable in workflow (#1933) * Fix missing variable name * Remove phpunit failOnWarning * Tests * PCOV Use Laravel 11 * Fixes for ButtonGroupColumn, ImageColumn, LinkColumn - to not default as label if has a "from" property. (#1932) * Initial Commit - Allowing Labels with "From" to be included in queries * Fix styling * Fixes for ButtonGroupColumn, ImageColumn, LinkColumn - to not default as label if has a "from" property. --------- Co-authored-by: lrljoe <[email protected]> * Add button type to tailwind pagination blade template (#1928) * v3.4.19 ChangeLog * Revert tableName to be public (#1937) * v3.4.20 ChangeLog * Migration to Core attribute management (#1943) * Migration to Core attribute management * Fix styling * Fix missing type hint, update tests * Fix styling * Remove defaults from being output * Fix styling * Adjust defaults * Adjust behaviour for Bulk Actions TH * Add "styling" to Columns docs * Docs Adjust, add missing test * Fix styling * Adjust workflows - use L11 for PHPStan, use PHPUnit for L10 * Add missing test for thSortIconAttributes * Fix styling * Add CustomAttributesTest * Fix styling * Add missing tests - correct attribute to respect defaults * Fix styling * Remove defined processes in workflows * Add test for setShouldBeHidden and setShouldBeDisplayed * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Update docs - add Action setLabelAttributes method (#1952) * Reset Page on "Per Page" changing (#1953) * Localisation - Avoid Conflicts With Other Packages (#1955) * Merging Localisation Tweaks * Fix styling * Tweak localisations * Fix styling * Tweaks to sorting pill direction label * Fix styling * Fixes for Sorting Pill Labels --------- Co-authored-by: lrljoe <[email protected]> * Add filterComponents into queryString (#1957) * Fix syntax for DateColumn outputFormat in docs (#1960) * Fix Filter Pills Icon - Tailwind (#1961) * Add original translation strings - for use in published views (#1959) * Fix for Search Field Attribute Defaults (#1962) * Fix for Search Field Attribute Defaults * SearchFieldAttributes -> Defaults To False * Change the type of LaravelLivewireTablesEvent::$user from Illuminate\Foundation\Auth\User to Illuminate\Contracts\Auth\Authenticatable (#1963) * Remove persist from getFilterGenericData (#1966) * Update ChangeLog * Update Pint Workflow (#1967) * Update Pint Workflow * Update ChangeLog * Test Styling Workflow * Fix styling * Test Workflow * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Update Discord Releases Workflow (#1968) * Update ChangeLog * Fix Loading Placeholder Bug - Breaking Table (#1969) * FixLoadingPlaceholderBug * Adjust tests for new Loading blade * v3.4.22 ChangeLog * Update ChangeLog * Add comment on getTitle (#1976) * Add before-wrapper and after-wrapper configurable areas (#1977) * Add initial commit for setPaginationWrapperAttributes (#1978) * Add initial commit for setPaginationWrapperAttributes * Fix styling * Update ChangeLog * Adjust Tests & Methods * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Update ChangeLog * Update ChangeLog * Adjust ChangeLog Date * Add ToolsAttributes and ToolbarAttributes (#1982) * Initial Commit * Fix styling * Add getCustomAttributesBagFromArray * Fix styling * Reorder Array * Reorder Initial Array - Add Additional Test * Fix styling * Add More Tests --------- Co-authored-by: lrljoe <[email protected]> * Add docs for the ColumnSelect lifecycle hooks (#1983) * Add setToolsAttributes and setToolBarAttributes docs (#1984) * Update ChangeLog * Adding Tools/Toolbar Enable Tests (#1986) * Adding Tools/Toolbar Enable Tests * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add lang Norwegian and Albanian (#1988) * Add Norwegian Bokmål nb.json GTP translated verified by human * Added Albanian sq.json GTP translated, not verified by human * Fix missing i18n keys for FR, IT, EN, DE (#1993) * Clean localization files by adding missing keys (in english) and re-ordering a few misplaced ones * Update localization for french * Update localization for spanish * Update localization for italian * Update localization for german * Revert "Clean localization files by adding missing keys (in english) and re-ordering a few misplaced ones" This reverts commit d440bd2. * Loading Placeholder Adjustments (#1987) * Move LoadingPlaceholderStyling into new method * Add "Loading" default translation * Move Placeholder Blade Config backwards * Adjustments to Placeholder Attributes * Tweak Row Behaviour --------- Co-authored-by: lrljoe <[email protected]> * Livewire column doesn't have title() method (#2002) Adjusting Documentation -> The Livewire column type doesn't have the `HasTitleCallback` trait, so you can't use `->title()`. * Add Value to BooleanColumn custom view (#2010) * Add Value to BooleanColumn view * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add config option to bypass setting User on Events. (#2006) Co-authored-by: julianmedwards <[email protected]> * Fix styling * Improve Workflow Caches (#2013) * Improve Workflow Caches * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add customisation for QueryString specific to Filters (#2011) * Add customisation for QueryString specific to Filters * Move all QueryString Filter Code to HasQueryStringForFilter --------- Co-authored-by: lrljoe <[email protected]> * Adjust Workflow Cache for Issue (#2015) * Fix bug with FilterQueryString (#2014) * Fix bug with FilterQueryString * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add Customisation for "Search" in QueryString (#2017) * AddSearchQueryString * Add tests for hasQueryStringAliasFor... * Additional Tests For SearchQueryString * Move Livewire to Visuals section * Simplify the queryString methods * Add hasQueryStringAliasForSearch test * PCOV Runs as PHPUnit not ParaTest * Remove PCOV From Workflows Where Not Used * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add QueryStringForSort (#2018) * Add QueryStringForSort * Adjust for SortQueryString * Tests * Tweaks to Configure Approach --------- Co-authored-by: lrljoe <[email protected]> * BETA: Livewire Custom Filter (Array) (#2025) * Initial Commit * Add blade for Livewire Component Array Filter - not live --------- Co-authored-by: lrljoe <[email protected]> * Fix bug #1997 - Found the issue elsewhere also, so I fixed them too. (#2021) * Adds Swedish translations (#2027) * Adds Swedish translations * Update weird translation strings I was stressed (: * Update sv.json --------- Co-authored-by: lrljoe <[email protected]> Co-authored-by: Matthias Schmitt <[email protected]> Co-authored-by: Paoulo Riveros <[email protected]> Co-authored-by: Christian <[email protected]> Co-authored-by: Chris Thompson <[email protected]> Co-authored-by: Julian Edwards <[email protected]> Co-authored-by: julianmedwards <[email protected]> Co-authored-by: Richard Leishman <[email protected]> Co-authored-by: Alex Bierhance <[email protected]>
lrljoe
added a commit
that referenced
this pull request
Nov 6, 2024
* Add explanation of setRefreshMethod (#1857) * Unlocking Entangled Items (#1859) * Unlock properties locked in error --------- Co-authored-by: lrljoe <[email protected]> * Add dispatch on updated filter components (#1861) * Add additional dispatch * Add FilterApplied Event * Add Filter Event Dispatch Tests --------- Co-authored-by: lrljoe <[email protected]> * v3.4.8 * Fix superfluous bulk actions tr < (#1868) * Default useComputedProperties to False (#1869) * Update ChangeLog * Add Action Buttons (#1864) * Make ActionButtons An Optional Feature in Beta --------- Co-authored-by: lrljoe <[email protected]> * FixDateRangeFilter (#1872) * Adjust Methods - useComputedProperties (#1873) * Adjust Methods - useComputedProperties * Adjust ActionTest * Update ChangeLog * AllowDeleteDateRangeFilter (#1875) * Fix ChangeLog * Update Docs (#1876) * Update ChangeLog - Add Docs Update * Add setIconLeft/setIconRight (#1877) * Add setIconLeft/setIconRight * Fix styling * Adjust Test * Adjust ActionTest --------- Co-authored-by: lrljoe <[email protected]> * Adjust ChangeLog * Adjust Action Button Icon Margin (#1880) * Adjust Action Button Icon Margin * Adjust ChangeLog * Change Order of "Getting Started" section (#1883) * Change Order of "Getting Started" section * Change to "UsersTable" * Add Button with No Icon (#1887) * Add a "Recommended" approach (#1886) * Add a "Recommended" approach * Add blurb to Recommended * v3.4.13 * Set actions position (#1889) * Add displayActionsInToolbar and actionsPosition * Add docs and tests for setActionsInToolbar * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Update ChangeLog * Doc Type Fixes (#1891) * Update NumberFilter and TypeHints * Update DateFilter/DateTimeFilter and ConfigurableAreasHelpers for typehints and array key exists * Add Float Test for NumberFilter * Add ColorColumn View Test * Adjust ColumnSelectConfigurationTest --------- Co-authored-by: lrljoe <[email protected]> * BooleanColumn - Toggleable Callback (#1892) * Add Docs, Code for Toggleable Columns * Add Confirmation Option * Tweak Blade - Standardise * Add Tests for Toggleable --------- Co-authored-by: lrljoe <[email protected]> * Update ChangeLog * Enable/Disable Tools/Toolbar (#1896) * Customised Toolbar Approach --------- Co-authored-by: lrljoe <[email protected]> * Use Computed Properties By Default (#1898) * Fix has actions (#1901) * Fix Action Repetitive Calling * Fix validActionsCount --------- Co-authored-by: lrljoe <[email protected]> * Add icon column (#1902) * Initial Commit - Awaiting Docs & Tests * Tweak to IconColumn label behaviour * Adding IconColumn documentation * Add Additional Tests - Replace Test Database * Add Visuals Test for IconColumn * Add Icon Columns to Other Column Types * Undo FrontendAssetsTest Changes --------- Co-authored-by: lrljoe <[email protected]> * Add Baseline - Convert phpstan.neon to tabs (#1903) * Update ChangeLog * Save filter selection to session (BETA) (#1910) * Initial Commit * Fix styling * Initial Commit * Fix styling * Fix nullable return * Add Initial Tests - Remove Non-Required Method * Fix styling * Swap methods * Add default docs * Remove errant note * Adjust docs * Adjust Docs for storeFiltersInSessionEnabled --------- Co-authored-by: lrljoe <[email protected]> * Add hide table option (#1914) * Initial Commit * Fix styling * Further adjustments * Fix styling * Improve Tests - Extend PetsTable * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add column select session methods (#1913) * Initial Commit * Fix styling * Minor Tweaks * Fix styling * Fix Tests * Add Tests for StoredColumnSelect * Fix styling * Add Missing Tests * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Use Core HasTheme Methods (#1915) * Centralise Theme Methods * Fix styling * Fix for broken tests * Fix styling * Remove persisted computed properties --------- Co-authored-by: lrljoe <[email protected]> * Use Core Attribute Bag (#1916) * Initial Commit * Fix styling * Add Missing Test * Fix styling * Adjustments * Fix styling * Adjust Test * Fix styling * Fix Sorting Visual Test --------- Co-authored-by: lrljoe <[email protected]> * Fix ChangeLog * Add Polish translation by @meavric (#1925) * Add Polish translation by @meavric * Update ChangeLog to reflect translation * Add Vertical Scrolling Example (#1926) * Adjusting contributing * Fix missing variable in workflow (#1933) * Fix missing variable name * Remove phpunit failOnWarning * Tests * PCOV Use Laravel 11 * Fixes for ButtonGroupColumn, ImageColumn, LinkColumn - to not default as label if has a "from" property. (#1932) * Initial Commit - Allowing Labels with "From" to be included in queries * Fix styling * Fixes for ButtonGroupColumn, ImageColumn, LinkColumn - to not default as label if has a "from" property. --------- Co-authored-by: lrljoe <[email protected]> * Add button type to tailwind pagination blade template (#1928) * v3.4.19 ChangeLog * Revert tableName to be public (#1937) * v3.4.20 ChangeLog * Migration to Core attribute management (#1943) * Migration to Core attribute management * Fix styling * Fix missing type hint, update tests * Fix styling * Remove defaults from being output * Fix styling * Adjust defaults * Adjust behaviour for Bulk Actions TH * Add "styling" to Columns docs * Docs Adjust, add missing test * Fix styling * Adjust workflows - use L11 for PHPStan, use PHPUnit for L10 * Add missing test for thSortIconAttributes * Fix styling * Add CustomAttributesTest * Fix styling * Add missing tests - correct attribute to respect defaults * Fix styling * Remove defined processes in workflows * Add test for setShouldBeHidden and setShouldBeDisplayed * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Update docs - add Action setLabelAttributes method (#1952) * Reset Page on "Per Page" changing (#1953) * Localisation - Avoid Conflicts With Other Packages (#1955) * Merging Localisation Tweaks * Fix styling * Tweak localisations * Fix styling * Tweaks to sorting pill direction label * Fix styling * Fixes for Sorting Pill Labels --------- Co-authored-by: lrljoe <[email protected]> * Add filterComponents into queryString (#1957) * Fix syntax for DateColumn outputFormat in docs (#1960) * Fix Filter Pills Icon - Tailwind (#1961) * Add original translation strings - for use in published views (#1959) * Fix for Search Field Attribute Defaults (#1962) * Fix for Search Field Attribute Defaults * SearchFieldAttributes -> Defaults To False * Change the type of LaravelLivewireTablesEvent::$user from Illuminate\Foundation\Auth\User to Illuminate\Contracts\Auth\Authenticatable (#1963) * Remove persist from getFilterGenericData (#1966) * Update ChangeLog * Update Pint Workflow (#1967) * Update Pint Workflow * Update ChangeLog * Test Styling Workflow * Fix styling * Test Workflow * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Update Discord Releases Workflow (#1968) * Update ChangeLog * Fix Loading Placeholder Bug - Breaking Table (#1969) * FixLoadingPlaceholderBug * Adjust tests for new Loading blade * v3.4.22 ChangeLog * Update ChangeLog * Add comment on getTitle (#1976) * Add before-wrapper and after-wrapper configurable areas (#1977) * Add initial commit for setPaginationWrapperAttributes (#1978) * Add initial commit for setPaginationWrapperAttributes * Fix styling * Update ChangeLog * Adjust Tests & Methods * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Update ChangeLog * Update ChangeLog * Adjust ChangeLog Date * Add ToolsAttributes and ToolbarAttributes (#1982) * Initial Commit * Fix styling * Add getCustomAttributesBagFromArray * Fix styling * Reorder Array * Reorder Initial Array - Add Additional Test * Fix styling * Add More Tests --------- Co-authored-by: lrljoe <[email protected]> * Add docs for the ColumnSelect lifecycle hooks (#1983) * Add setToolsAttributes and setToolBarAttributes docs (#1984) * Update ChangeLog * Adding Tools/Toolbar Enable Tests (#1986) * Adding Tools/Toolbar Enable Tests * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add lang Norwegian and Albanian (#1988) * Add Norwegian Bokmål nb.json GTP translated verified by human * Added Albanian sq.json GTP translated, not verified by human * Fix missing i18n keys for FR, IT, EN, DE (#1993) * Clean localization files by adding missing keys (in english) and re-ordering a few misplaced ones * Update localization for french * Update localization for spanish * Update localization for italian * Update localization for german * Revert "Clean localization files by adding missing keys (in english) and re-ordering a few misplaced ones" This reverts commit d440bd2. * Loading Placeholder Adjustments (#1987) * Move LoadingPlaceholderStyling into new method * Add "Loading" default translation * Move Placeholder Blade Config backwards * Adjustments to Placeholder Attributes * Tweak Row Behaviour --------- Co-authored-by: lrljoe <[email protected]> * Livewire column doesn't have title() method (#2002) Adjusting Documentation -> The Livewire column type doesn't have the `HasTitleCallback` trait, so you can't use `->title()`. * Add Value to BooleanColumn custom view (#2010) * Add Value to BooleanColumn view * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add config option to bypass setting User on Events. (#2006) Co-authored-by: julianmedwards <[email protected]> * Fix styling * Improve Workflow Caches (#2013) * Improve Workflow Caches * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add customisation for QueryString specific to Filters (#2011) * Add customisation for QueryString specific to Filters * Move all QueryString Filter Code to HasQueryStringForFilter --------- Co-authored-by: lrljoe <[email protected]> * Adjust Workflow Cache for Issue (#2015) * Fix bug with FilterQueryString (#2014) * Fix bug with FilterQueryString * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add Customisation for "Search" in QueryString (#2017) * AddSearchQueryString * Add tests for hasQueryStringAliasFor... * Additional Tests For SearchQueryString * Move Livewire to Visuals section * Simplify the queryString methods * Add hasQueryStringAliasForSearch test * PCOV Runs as PHPUnit not ParaTest * Remove PCOV From Workflows Where Not Used * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add QueryStringForSort (#2018) * Add QueryStringForSort * Adjust for SortQueryString * Tests * Tweaks to Configure Approach --------- Co-authored-by: lrljoe <[email protected]> * BETA: Livewire Custom Filter (Array) (#2025) * Initial Commit * Add blade for Livewire Component Array Filter - not live --------- Co-authored-by: lrljoe <[email protected]> * Fix bug #1997 - Found the issue elsewhere also, so I fixed them too. (#2021) * Adds Swedish translations (#2027) * Adds Swedish translations * Update weird translation strings I was stressed (: * Update sv.json * Adjust ChangeLog for 3.5.0 --------- Co-authored-by: lrljoe <[email protected]> Co-authored-by: Matthias Schmitt <[email protected]> Co-authored-by: Paoulo Riveros <[email protected]> Co-authored-by: Christian <[email protected]> Co-authored-by: Chris Thompson <[email protected]> Co-authored-by: Julian Edwards <[email protected]> Co-authored-by: julianmedwards <[email protected]> Co-authored-by: Richard Leishman <[email protected]> Co-authored-by: Alex Bierhance <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO DO:
All Submissions:
New Feature Submissions:
Changes to Core Features: