Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - Column - Allow Enum in ReturnType for Column getContent/renderContent #1436

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Oct 23, 2023

This fix is to allow casted columns via Enum.

Tests for this will follow in future versions.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #1436 (929e56a) into v3-develop (cb2d9c9) will not change coverage.
Report is 3 commits behind head on v3-develop.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             v3-develop    #1436   +/-   ##
=============================================
  Coverage         88.00%   88.00%           
  Complexity         1210     1210           
=============================================
  Files                85       85           
  Lines              2950     2950           
=============================================
  Hits               2596     2596           
  Misses              354      354           
Files Coverage Δ
src/Views/Traits/Helpers/ColumnHelpers.php 90.86% <100.00%> (ø)

@lrljoe lrljoe merged commit b4c07dc into rappasoft:v3-develop Oct 23, 2023
6 checks passed
lrljoe added a commit that referenced this pull request Oct 25, 2023
Co-authored-by: lrljoe <[email protected]>

* v3 - Adding CollapseAlways Option for Columns (#1403)

* Add CollapseAlways & Fix ReorderColumn

* Remove superfluous md:hidden from the icon

* Tweaks for Column Collapsing For BS4/BS5

* Fix Collapsed on Bootstrap

* Tweak Bootstrap Theme

---------

Co-authored-by: lrljoe <[email protected]>

* Minor tweaks to blades for reorder cols (#1411)

* V3 - Fix Reorder For Bootstrap (#1412)

* Minor tweaks to blades for reorder cols

* Bootstrap Reorder Toggle

* Add DiscordBot (#1413)

* Docs livewire namespace fix (#1420)

* Fixed Livewire namespace in docs

* Updated livewire url in docs

* V3  - Fix Localisation (#1424)

* Fix Localisations

* Fix styling

* Load Original and Publish Localisation Paths

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Add Loading Placeholder (#1421)

* Initial Loading Placeholder Code, Use Hourglass Spinner

* Add wrappers, Class Merging, Colouring

* Renaming Traits - Adding LoadingPlaceholder Tests, Add Placeholder Test Table

* Update Docs for Placeholder

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Column - Allow Enum in ReturnType for Column getContent/renderContent (#1436)

* Fix Enum Column Return TypeHints

* v3 - Add "Confirmation" Option to Bulk Actions (#1437)

* Add BulkActionConfirms

* Add wire:confirm capability to bulk actions

* Update Changelog

* Fix error with typehinting

* Add Tests

* Adding default confirmation message customisation

* Update Default Message

* Update Tests

---------

Co-authored-by: lrljoe <[email protected]>

---------

Co-authored-by: lrljoe <[email protected]>
Co-authored-by: Anthony Rappa <[email protected]>
@lrljoe lrljoe deleted the v3-ColumnGetContents-ReturnTypeFix branch October 31, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant