-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 - Full Page Table Component Options #1430
v3 - Full Page Table Component Options #1430
Conversation
Codecov Report
@@ Coverage Diff @@
## v3-develop #1430 +/- ##
================================================
+ Coverage 88.08% 88.09% +0.01%
- Complexity 1251 1267 +16
================================================
Files 88 88
Lines 3013 3050 +37
================================================
+ Hits 2654 2687 +33
- Misses 359 363 +4
|
Two other items that may be really useful to add for enabling full page components is perhaps a:
As Livewire 3 offers this now:
So a full page component should offer the ability to add in headers. And a page title method:
which should match up with:
Ultimately, plan is to expose render(), but I'm 99% that's a v4 thing. |
0e96d7b
to
71c2602
Compare
@lrljoe I've added the helper methods as you suggested, but havn't added the title and headers method, will do them in a new pr |
Sounds good, I'll review this weekend as have a few PRs to review and merge. Thank you! |
Few conflicts, but that's due to other changes that have happened since you first forked, and are very recent (such as adding hook methods, moving bits out of rendering etc). At this point, I imagine I'll end up moving your code into a trait of its own for a "WithFullPageComponentMethods" or similar. Sadly this PR has come in right when I'm moving bits around, but it definitely won't go to waste! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Replaced by #1580 |
This PR adds different configuration options for setting up a full-page component for livewire
https://livewire.laravel.com/docs/components#full-page-components
The following methods have been added:
setLayout
for setting layout for component (https://livewire.laravel.com/docs/components#per-component-layout-configuration)setSlot
setExtends
setSection