Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - Add Hide Column Label #1426

Closed
wants to merge 10 commits into from

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Oct 17, 2023

Adds the ability, per-column to hide the Column Label

PENDING TESTS

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1426 (77f22fb) into v3-develop (cb2d9c9) will increase coverage by 0.04%.
Report is 3 commits behind head on v3-develop.
The diff coverage is 100.00%.

❗ Current head 77f22fb differs from pull request most recent head d061fcd. Consider uploading reports for the commit d061fcd to get more accurate results

@@               Coverage Diff                @@
##             v3-develop    #1426      +/-   ##
================================================
+ Coverage         88.00%   88.04%   +0.04%     
- Complexity         1210     1214       +4     
================================================
  Files                85       85              
  Lines              2950     2960      +10     
================================================
+ Hits               2596     2606      +10     
  Misses              354      354              
Files Coverage Δ
src/Views/Column.php 100.00% <ø> (ø)
...Views/Traits/Configuration/ColumnConfiguration.php 100.00% <100.00%> (ø)
src/Views/Traits/Helpers/ColumnHelpers.php 90.95% <100.00%> (+0.09%) ⬆️

@lrljoe
Copy link
Collaborator Author

lrljoe commented Oct 18, 2023

Still need to:

  • Add more tests
  • Adjust docs

@lrljoe lrljoe linked an issue Oct 18, 2023 that may be closed by this pull request
@lrljoe lrljoe self-assigned this Oct 28, 2023
@lrljoe lrljoe changed the base branch from v3-develop to develop October 31, 2023 05:53
@lrljoe lrljoe closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: option to make column with empty heading
1 participant