Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder Col - respect setHideReorderColumnUnlessReorderingDisabled #1411

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Oct 13, 2023

Minor Tweak - Ensure that Reorder Column respects
setHideReorderColumnUnlessReorderingDisabled
setHideReorderColumnUnlessReorderingEnabled

All Submissions:

  • [X ] Have you followed the guidelines in our Contributing document?
  • [X ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1411 (8d49f3b) into v3-develop (9d42d0f) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             v3-develop    #1411   +/-   ##
=============================================
  Coverage         87.81%   87.81%           
  Complexity         1191     1191           
=============================================
  Files                83       83           
  Lines              2905     2905           
=============================================
  Hits               2551     2551           
  Misses              354      354           

@lrljoe lrljoe merged commit 31ae8fe into rappasoft:v3-develop Oct 13, 2023
6 checks passed
lrljoe added a commit that referenced this pull request Oct 13, 2023
* Beta Fixes - Publishing Views/Localizations.  Beta Improvements - Search Options (#1324)

* Update setSearchDebounce, add setSearchThrottle/setSearchBlur

* Remove Lazy Test

* Remove Lazy Tests - Update Docs

* Update Views Publish Path

* Add Translations Publish Option

* Update ChangeLog

* Add Reusable Columns

* Add Tests for Prepend/Append Cols

---------

Co-authored-by: lrljoe <[email protected]>

* Bulk Actions Fix - v3 (#1326)

* Update setSearchDebounce, add setSearchThrottle/setSearchBlur

* Remove Lazy Test

* Remove Lazy Tests - Update Docs

* Update Views Publish Path

* Add Translations Publish Option

* Update ChangeLog

* Add Reusable Columns

* Add Tests for Prepend/Append Cols

* Column Select Fixes

* Fix test

* Add docs for setSearchPlaceholder

* Move Filter Specific Docs ino Filter-Types

* Fix styling

* Remove extraneous space

* Adjusting Selectable Test

* Fix For BulkActions Dropdown

* Fixes for ColumnSelect

* Update ChangeLog

* Test Fix for Selectable Columns

* Remove Faulty Test

---------

Co-authored-by: lrljoe <[email protected]>

* Fix Column Select - Select All state (#1333)

* Fix Column Select - All

* Update ChangeLog

* Add NonArray setAdditionalSelects Test (#1337)

* Test Additions (#1339)

* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Add Third Party Tests (#1340)

* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Add ThirdPartyScripts/Styles to Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Third Party Asset Tests (#1341)

* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Add ThirdPartyScripts/Styles to Test

* Add ThirdParty Tests

* Fix AutoInjection Issue

* Fix 3rd party test

* Set default back to remote 3rd party assets

* Add CodeCov YML

* Update CodeCov - 80% minimum

* Add Filter Custom Pills Blade Test

* Fix styling

* Add formatted column test

* Column - Get Formatted Contents Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Lazy Loading Fix (#1355)

* Add fix for lazy loading

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Spacing fixes

* v3 - Missing Tests - Pagination Related Tests (#1363)

* Add missing pagination helper tests


---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Missing Tests - Broken Tables (Missing Primary Key/Builder) (#1362)

* Add missing component visuals tests & failed tables

* Update Exception Expectation

* Temporary test swapping to check Exception throwing

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Add setSearchFieldAttribute Options (#1361)

* Add setSearchFieldAttribute Options


---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Column Select Fixes & Tweaks (#1360)

* ColumnSelect Fixes - Phase 1

* Update "Select All" to use counts

* Missing closing bracket

* All Are Selected -> Move to method in Helpers

* ColSelectFixes

* Ensure event fires

* Update ColumnsSelectedTest

* Fix superfluous empty array return

* Remove superfluous default return

* Adjust Tests - Include Coverage For ExcludeDeselectedCols

* Add Tests For AllColsSelected

* Fix styling

* Fixes for Deselected Cols

* Fix styling

* Updates to Changelog

* Removing ColumnSelected Event Test - Temporary

* Add default true to replace removed test

* Add improved test

---------

Co-authored-by: lrljoe <[email protected]>

* Fix ServiceProvider Fault (#1366)

* V3 Frontend Asset Tweaks (#1371)

* Check for "original" property

* Adjusting order of request validations

* Updates to Asset Injection Methods

* Fix assertViewIs is not working (#67)
Contribs By: Jackson Tong <[email protected]

* Tweaks for Auto Injection Options

* Test Updates - Frontend Assets

* Add ThirdParty Basic Header Tests

* Add Initial Debuggable DTO Test

* V3 - Reordering Fixes (#1373)

* Reordering Fixes - Performance & Toggling

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Bundler Import Options (#1377)

* Add All Option

* Update Import Paths

* Add minified CSS Versions

* V3 Restore setTrAttributes (#1378)

* Add setTrAttributes back into use

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Update Reorder Documentation (#1381)

* Update Reorder Documentation

* Update ChangeLog - Merge Unreleased

* Update Docs - Advanced Example, Add Including Assets (#1383)

* Fix DateRangeFilter Blade Items (#1394)

* Add setFilterLabelAttributes Capability (#1397)

* Add setFilterLabelAttributes Capability

* Update filter-label to use customLabelAttributes to avoid any potential conflicts

* Adjust documentation for setCustomFilterLabel

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Apply Reorder Sorting When Reordering (#1402)

* Fix for reorder sort not applying

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Fix Unrequired Update Call (#1407)

* Fixes for Additional Update

* Increase cache time to 1 day from 1 hour

* Fix tests for cache time

* Update mapping to use min.css

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Adding CollapseAlways Option for Columns (#1403)

* Add CollapseAlways & Fix ReorderColumn

* Remove superfluous md:hidden from the icon

* Tweaks for Column Collapsing For BS4/BS5

* Fix Collapsed on Bootstrap

* Tweak Bootstrap Theme

---------

Co-authored-by: lrljoe <[email protected]>

* Minor tweaks to blades for reorder cols (#1411)

* V3 - Fix Reorder For Bootstrap (#1412)

* Minor tweaks to blades for reorder cols

* Bootstrap Reorder Toggle

* Add DiscordBot (#1413)

---------

Co-authored-by: lrljoe <[email protected]>
Co-authored-by: Anthony Rappa <[email protected]>
lrljoe added a commit to LowerRockLabs/laravel-livewire-tables that referenced this pull request Oct 17, 2023
* Beta Fixes - Publishing Views/Localizations.  Beta Improvements - Search Options (rappasoft#1324)

* Update setSearchDebounce, add setSearchThrottle/setSearchBlur

* Remove Lazy Tests - Update Docs

* Update Views Publish Path

* Add Translations Publish Option

* Update ChangeLog

* Add Reusable Columns

* Add Tests for Prepend/Append Cols

---------

Co-authored-by: lrljoe <[email protected]>

* Bulk Actions Fix - v3 (rappasoft#1326)

* Update setSearchDebounce, add setSearchThrottle/setSearchBlur

* Remove Lazy Test

* Remove Lazy Tests - Update Docs

* Update Views Publish Path

* Add Translations Publish Option

* Update ChangeLog

* Add Reusable Columns

* Add Tests for Prepend/Append Cols

* Column Select Fixes

* Fix test

* Add docs for setSearchPlaceholder

* Move Filter Specific Docs ino Filter-Types

* Fix styling

* Remove extraneous space

* Adjusting Selectable Test

* Fix For BulkActions Dropdown

* Fixes for ColumnSelect

* Update ChangeLog

* Test Fix for Selectable Columns

* Remove Faulty Test

---------

Co-authored-by: lrljoe <[email protected]>

* Fix Column Select - Select All state (rappasoft#1333)

* Fix Column Select - All

* Update ChangeLog

* Add NonArray setAdditionalSelects Test (rappasoft#1337)

* Test Additions (rappasoft#1339)

* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Add Third Party Tests (rappasoft#1340)

* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Add ThirdPartyScripts/Styles to Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Third Party Asset Tests (rappasoft#1341)

* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Add ThirdPartyScripts/Styles to Test

* Add ThirdParty Tests

* Fix AutoInjection Issue

* Fix 3rd party test

* Set default back to remote 3rd party assets

* Add CodeCov YML

* Update CodeCov - 80% minimum

* Add Filter Custom Pills Blade Test

* Fix styling

* Add formatted column test

* Column - Get Formatted Contents Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Lazy Loading Fix (rappasoft#1355)

* Add fix for lazy loading

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Spacing fixes

* v3 - Missing Tests - Pagination Related Tests (rappasoft#1363)

* Add missing pagination helper tests


---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Missing Tests - Broken Tables (Missing Primary Key/Builder) (rappasoft#1362)

* Add missing component visuals tests & failed tables

* Update Exception Expectation

* Temporary test swapping to check Exception throwing

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Add setSearchFieldAttribute Options (rappasoft#1361)

* Add setSearchFieldAttribute Options


---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Column Select Fixes & Tweaks (rappasoft#1360)

* ColumnSelect Fixes - Phase 1

* Update "Select All" to use counts

* Missing closing bracket

* All Are Selected -> Move to method in Helpers

* ColSelectFixes

* Ensure event fires

* Update ColumnsSelectedTest

* Fix superfluous empty array return

* Remove superfluous default return

* Adjust Tests - Include Coverage For ExcludeDeselectedCols

* Add Tests For AllColsSelected

* Fix styling

* Fixes for Deselected Cols

* Fix styling

* Updates to Changelog

* Removing ColumnSelected Event Test - Temporary

* Add default true to replace removed test

* Add improved test

---------

Co-authored-by: lrljoe <[email protected]>

* Fix ServiceProvider Fault (rappasoft#1366)

* V3 Frontend Asset Tweaks (rappasoft#1371)

* Check for "original" property

* Adjusting order of request validations

* Updates to Asset Injection Methods

* Fix assertViewIs is not working (#67)
Contribs By: Jackson Tong <[email protected]

* Tweaks for Auto Injection Options

* Test Updates - Frontend Assets

* Add ThirdParty Basic Header Tests

* Add Initial Debuggable DTO Test

* V3 - Reordering Fixes (rappasoft#1373)

* Reordering Fixes - Performance & Toggling

* Fix styling
---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Apply Reorder Sorting When Reordering (rappasoft#1402)

* Fix for reorder sort not applying

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Fix Unrequired Update Call (rappasoft#1407)

* Fixes for Additional Update

* Increase cache time to 1 day from 1 hour

* Fix tests for cache time

* Update mapping to use min.css

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Adding CollapseAlways Option for Columns (rappasoft#1403)

* Add CollapseAlways & Fix ReorderColumn

* Remove superfluous md:hidden from the icon

* Tweaks for Column Collapsing For BS4/BS5

* Fix Collapsed on Bootstrap

* Tweak Bootstrap Theme

---------

Co-authored-by: lrljoe <[email protected]>

* Minor tweaks to blades for reorder cols (rappasoft#1411)

* V3 - Fix Reorder For Bootstrap (rappasoft#1412)

* Minor tweaks to blades for reorder cols

* Bootstrap Reorder Toggle

* Add DiscordBot (rappasoft#1413)

---------

Co-authored-by: lrljoe <[email protected]>

* Docs livewire namespace fix (rappasoft#1420)

* Fixed Livewire namespace in docs

* Updated livewire url in docs

---------

Co-authored-by: Abdul Majeed Shehzad <[email protected]>

* V3  - Fix Localisation (rappasoft#1424)

* Fix Localisations

* Load Original and Publish Localisation Paths

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Add Loading Placeholder (rappasoft#1421)

* Initial Loading Placeholder Code, Use Hourglass Spinner

* Add wrappers, Class Merging, Colouring

* Renaming Traits - Adding LoadingPlaceholder Tests, Add Placeholder Test Table

* Update Docs for Placeholder

---------
lrljoe added a commit that referenced this pull request Oct 17, 2023
* Beta Fixes - Publishing Views/Localizations.  Beta Improvements - Search Options (#1324)

* Update setSearchDebounce, add setSearchThrottle/setSearchBlur

* Remove Lazy Test

* Remove Lazy Tests - Update Docs

* Update Views Publish Path

* Add Translations Publish Option

* Update ChangeLog

* Add Reusable Columns

* Add Tests for Prepend/Append Cols

---------

Co-authored-by: lrljoe <[email protected]>

* Bulk Actions Fix - v3 (#1326)

* Update setSearchDebounce, add setSearchThrottle/setSearchBlur

* Remove Lazy Test

* Remove Lazy Tests - Update Docs

* Update Views Publish Path

* Add Translations Publish Option

* Update ChangeLog

* Add Reusable Columns

* Add Tests for Prepend/Append Cols

* Column Select Fixes

* Fix test

* Add docs for setSearchPlaceholder

* Move Filter Specific Docs ino Filter-Types

* Fix styling

* Remove extraneous space

* Adjusting Selectable Test

* Fix For BulkActions Dropdown

* Fixes for ColumnSelect

* Update ChangeLog

* Test Fix for Selectable Columns

* Remove Faulty Test

---------

Co-authored-by: lrljoe <[email protected]>

* Fix Column Select - Select All state (#1333)

* Fix Column Select - All

* Update ChangeLog

* Add NonArray setAdditionalSelects Test (#1337)

* Test Additions (#1339)

* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Add Third Party Tests (#1340)

* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Add ThirdPartyScripts/Styles to Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Third Party Asset Tests (#1341)

* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Add ThirdPartyScripts/Styles to Test

* Add ThirdParty Tests

* Fix AutoInjection Issue

* Fix 3rd party test

* Set default back to remote 3rd party assets

* Add CodeCov YML

* Update CodeCov - 80% minimum

* Add Filter Custom Pills Blade Test

* Fix styling

* Add formatted column test

* Column - Get Formatted Contents Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Lazy Loading Fix (#1355)

* Add fix for lazy loading

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Spacing fixes

* v3 - Missing Tests - Pagination Related Tests (#1363)

* Add missing pagination helper tests


---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Missing Tests - Broken Tables (Missing Primary Key/Builder) (#1362)

* Add missing component visuals tests & failed tables

* Update Exception Expectation

* Temporary test swapping to check Exception throwing

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Add setSearchFieldAttribute Options (#1361)

* Add setSearchFieldAttribute Options


---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Column Select Fixes & Tweaks (#1360)

* ColumnSelect Fixes - Phase 1

* Update "Select All" to use counts

* Missing closing bracket

* All Are Selected -> Move to method in Helpers

* ColSelectFixes

* Ensure event fires

* Update ColumnsSelectedTest

* Fix superfluous empty array return

* Remove superfluous default return

* Adjust Tests - Include Coverage For ExcludeDeselectedCols

* Add Tests For AllColsSelected

* Fix styling

* Fixes for Deselected Cols

* Fix styling

* Updates to Changelog

* Removing ColumnSelected Event Test - Temporary

* Add default true to replace removed test

* Add improved test

---------

Co-authored-by: lrljoe <[email protected]>

* Fix ServiceProvider Fault (#1366)

* V3 Frontend Asset Tweaks (#1371)

* Check for "original" property

* Adjusting order of request validations

* Updates to Asset Injection Methods

* Fix assertViewIs is not working (#67)
Contribs By: Jackson Tong <[email protected]

* Tweaks for Auto Injection Options

* Test Updates - Frontend Assets

* Add ThirdParty Basic Header Tests

* Add Initial Debuggable DTO Test

* V3 - Reordering Fixes (#1373)

* Reordering Fixes - Performance & Toggling

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Bundler Import Options (#1377)

* Add All Option

* Update Import Paths

* Add minified CSS Versions

* V3 Restore setTrAttributes (#1378)

* Add setTrAttributes back into use

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Update Reorder Documentation (#1381)

* Update Reorder Documentation

* Update ChangeLog - Merge Unreleased

* Update Docs - Advanced Example, Add Including Assets (#1383)

* Fix DateRangeFilter Blade Items (#1394)

* Add setFilterLabelAttributes Capability (#1397)

* Add setFilterLabelAttributes Capability

* Update filter-label to use customLabelAttributes to avoid any potential conflicts

* Adjust documentation for setCustomFilterLabel

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Apply Reorder Sorting When Reordering (#1402)

* Fix for reorder sort not applying

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Fix Unrequired Update Call (#1407)

* Fixes for Additional Update

* Increase cache time to 1 day from 1 hour

* Fix tests for cache time

* Update mapping to use min.css

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Adding CollapseAlways Option for Columns (#1403)

* Add CollapseAlways & Fix ReorderColumn

* Remove superfluous md:hidden from the icon

* Tweaks for Column Collapsing For BS4/BS5

* Fix Collapsed on Bootstrap

* Tweak Bootstrap Theme

---------

Co-authored-by: lrljoe <[email protected]>

* Minor tweaks to blades for reorder cols (#1411)

* V3 - Fix Reorder For Bootstrap (#1412)

* Minor tweaks to blades for reorder cols

* Bootstrap Reorder Toggle

* Add DiscordBot (#1413)

---------

Co-authored-by: Abdul Majeed Shehzad <[email protected]>

* Docs livewire namespace fix (#1420)

* Fixed Livewire namespace in docs

* Updated livewire url in docs

---------

Co-authored-by: lrljoe <[email protected]>

* V3  - Fix Localisation (#1424)

* Fix Localisations

* Fix styling

* Load Original and Publish Localisation Paths

* Fix styling

* v3 - Add Loading Placeholder (#1421)

* Initial Loading Placeholder Code, Use Hourglass Spinner

* Add wrappers, Class Merging, Colouring

* Renaming Traits - Adding LoadingPlaceholder Tests, Add Placeholder Test Table

* Update Docs for Placeholder

---------

Co-authored-by: lrljoe <[email protected]>

---------

Co-authored-by: lrljoe <[email protected]>
Co-authored-by: Anthony Rappa <[email protected]>
lrljoe added a commit that referenced this pull request Oct 25, 2023
Co-authored-by: lrljoe <[email protected]>

* v3 - Adding CollapseAlways Option for Columns (#1403)

* Add CollapseAlways & Fix ReorderColumn

* Remove superfluous md:hidden from the icon

* Tweaks for Column Collapsing For BS4/BS5

* Fix Collapsed on Bootstrap

* Tweak Bootstrap Theme

---------

Co-authored-by: lrljoe <[email protected]>

* Minor tweaks to blades for reorder cols (#1411)

* V3 - Fix Reorder For Bootstrap (#1412)

* Minor tweaks to blades for reorder cols

* Bootstrap Reorder Toggle

* Add DiscordBot (#1413)

* Docs livewire namespace fix (#1420)

* Fixed Livewire namespace in docs

* Updated livewire url in docs

* V3  - Fix Localisation (#1424)

* Fix Localisations

* Fix styling

* Load Original and Publish Localisation Paths

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Add Loading Placeholder (#1421)

* Initial Loading Placeholder Code, Use Hourglass Spinner

* Add wrappers, Class Merging, Colouring

* Renaming Traits - Adding LoadingPlaceholder Tests, Add Placeholder Test Table

* Update Docs for Placeholder

---------

Co-authored-by: lrljoe <[email protected]>

* v3 - Column - Allow Enum in ReturnType for Column getContent/renderContent (#1436)

* Fix Enum Column Return TypeHints

* v3 - Add "Confirmation" Option to Bulk Actions (#1437)

* Add BulkActionConfirms

* Add wire:confirm capability to bulk actions

* Update Changelog

* Fix error with typehinting

* Add Tests

* Adding default confirmation message customisation

* Update Default Message

* Update Tests

---------

Co-authored-by: lrljoe <[email protected]>

---------

Co-authored-by: lrljoe <[email protected]>
Co-authored-by: Anthony Rappa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant