Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 - CollapseAlways() Option #1400

Closed
wants to merge 14 commits into from

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Oct 8, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #1400 (31c592a) into v3-develop (32de139) will increase coverage by 0.17%.
Report is 7 commits behind head on v3-develop.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##             v3-develop    #1400      +/-   ##
================================================
+ Coverage         87.63%   87.80%   +0.17%     
- Complexity         1165     1185      +20     
================================================
  Files                83       83              
  Lines              2862     2902      +40     
================================================
+ Hits               2508     2548      +40     
  Misses              354      354              
Files Coverage Δ
src/Traits/Configuration/ColumnConfiguration.php 76.92% <100.00%> (+4.19%) ⬆️
src/Traits/Helpers/ColumnHelpers.php 95.27% <100.00%> (+0.98%) ⬆️
src/Traits/WithColumns.php 100.00% <ø> (ø)
src/Traits/WithData.php 78.57% <100.00%> (+0.44%) ⬆️
src/Views/Column.php 100.00% <ø> (ø)
src/Views/Filter.php 100.00% <ø> (ø)
...Views/Traits/Configuration/FilterConfiguration.php 100.00% <100.00%> (ø)
src/Views/Traits/Helpers/ColumnHelpers.php 90.86% <100.00%> (+0.25%) ⬆️
src/Views/Traits/Helpers/FilterHelpers.php 97.26% <100.00%> (+0.15%) ⬆️

@lrljoe lrljoe closed this Oct 8, 2023
@lrljoe lrljoe deleted the v3-collapseOnAll branch October 31, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant