Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3-develop to v3-master #1399

Merged
merged 26 commits into from
Oct 8, 2023
Merged

v3-develop to v3-master #1399

merged 26 commits into from
Oct 8, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Oct 8, 2023 •
edited
Loading

Develop To Master Release for 3.0.0-beta.1

  • Removes superfluous @endphp from the DateRangeFilter blade
  • Removes reference to remote/published 3rd party assets
  • Add setFilterLabelAttributes Capability Per-Filter
  • Fixes reorderSort not applying smoothly

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 25 commits August 31, 2023 22:37
@lrljoe
Beta Fixes - Publishing Views/Localizations. Beta Improvements - Sear…
1d1da19 
…ch Options (#1324)

* Update setSearchDebounce, add setSearchThrottle/setSearchBlur

* Remove Lazy Test

* Remove Lazy Tests - Update Docs

* Update Views Publish Path

* Add Translations Publish Option

* Update ChangeLog

* Add Reusable Columns

* Add Tests for Prepend/Append Cols

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
Bulk Actions Fix - v3 (#1326)
135297e 
* Update setSearchDebounce, add setSearchThrottle/setSearchBlur

* Remove Lazy Test

* Remove Lazy Tests - Update Docs

* Update Views Publish Path

* Add Translations Publish Option

* Update ChangeLog

* Add Reusable Columns

* Add Tests for Prepend/Append Cols

* Column Select Fixes

* Fix test

* Add docs for setSearchPlaceholder

* Move Filter Specific Docs ino Filter-Types

* Fix styling

* Remove extraneous space

* Adjusting Selectable Test

* Fix For BulkActions Dropdown

* Fixes for ColumnSelect

* Update ChangeLog

* Test Fix for Selectable Columns

* Remove Faulty Test

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
Fix Column Select - Select All state (#1333)
3967e15 
* Fix Column Select - All

* Update ChangeLog
@lrljoe
Merge branch 'v3-master' into v3-develop
648a6ca
@lrljoe
Add NonArray setAdditionalSelects Test (#1337)
4ee351e
@lrljoe
Test Additions (#1339)
32556cd 
* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
Add Third Party Tests (#1340)
9ec84f1 
* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Add ThirdPartyScripts/Styles to Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
Third Party Asset Tests (#1341)
74b547c 
* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Add ThirdPartyScripts/Styles to Test

* Add ThirdParty Tests

* Fix AutoInjection Issue

* Fix 3rd party test

* Set default back to remote 3rd party assets

* Add CodeCov YML

* Update CodeCov - 80% minimum

* Add Filter Custom Pills Blade Test

* Fix styling

* Add formatted column test

* Column - Get Formatted Contents Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
Lazy Loading Fix (#1355)
b68ab26 
* Add fix for lazy loading

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
@rappasoft
Spacing fixes
e609f13
@lrljoe
v3 - Missing Tests - Pagination Related Tests (#1363)
d6e6512 
* Add missing pagination helper tests


---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
v3 - Missing Tests - Broken Tables (Missing Primary Key/Builder) (#1362)
ae87ac2 
* Add missing component visuals tests & failed tables

* Update Exception Expectation

* Temporary test swapping to check Exception throwing

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
v3 - Add setSearchFieldAttribute Options (#1361)
e2a3199 
* Add setSearchFieldAttribute Options


---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
v3 - Column Select Fixes & Tweaks (#1360)
e7c10c1 
* ColumnSelect Fixes - Phase 1

* Update "Select All" to use counts

* Missing closing bracket

* All Are Selected -> Move to method in Helpers

* ColSelectFixes

* Ensure event fires

* Update ColumnsSelectedTest

* Fix superfluous empty array return

* Remove superfluous default return

* Adjust Tests - Include Coverage For ExcludeDeselectedCols

* Add Tests For AllColsSelected

* Fix styling

* Fixes for Deselected Cols

* Fix styling

* Updates to Changelog

* Removing ColumnSelected Event Test - Temporary

* Add default true to replace removed test

* Add improved test

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
Fix ServiceProvider Fault (#1366)
62db217
@lrljoe
V3 Frontend Asset Tweaks (#1371)
65ce494 
* Check for "original" property

* Adjusting order of request validations

* Updates to Asset Injection Methods

* Fix assertViewIs is not working (#67)
Contribs By: Jackson Tong <[email protected]

* Tweaks for Auto Injection Options

* Test Updates - Frontend Assets

* Add ThirdParty Basic Header Tests

* Add Initial Debuggable DTO Test
@lrljoe
V3 - Reordering Fixes (#1373)
19b79b2 
* Reordering Fixes - Performance & Toggling

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
Bundler Import Options (#1377)
9cdf451 
* Add All Option

* Update Import Paths

* Add minified CSS Versions
@lrljoe
V3 Restore setTrAttributes (#1378)
6c977c4 
* Add setTrAttributes back into use

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
Update Reorder Documentation (#1381)
1e6c159 
* Update Reorder Documentation

* Update ChangeLog - Merge Unreleased
@lrljoe
Merge branch 'v3-master' into v3-develop
32de139
@lrljoe
Update Docs - Advanced Example, Add Including Assets (#1383)
66ece40
@lrljoe
Fix DateRangeFilter Blade Items (#1394)
154f726
@lrljoe
Add setFilterLabelAttributes Capability (#1397)
16ccfe1 
* Add setFilterLabelAttributes Capability

* Update filter-label to use customLabelAttributes to avoid any potential conflicts

* Adjust documentation for setCustomFilterLabel

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
Merge branch 'v3-master' into v3-develop
323deee
@codecov
Copy link

codecov bot commented Oct 8, 2023 •
edited
Loading

Codecov Report

Merging #1399 (323deee) into v3-master (c519a09) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 323deee differs from pull request most recent head 429b54f. Consider uploading reports for the commit 429b54f to get more accurate results

@@               Coverage Diff               @@
##             v3-master    #1399      +/-   ##
===============================================
+ Coverage        87.63%   87.66%   +0.03%     
- Complexity        1165     1169       +4     
===============================================
  Files               83       83              
  Lines             2862     2869       +7     
===============================================
+ Hits              2508     2515       +7     
  Misses             354      354
Files Coverage Δ
src/Views/Filter.php 100.00% <ø> (ø)
...Views/Traits/Configuration/FilterConfiguration.php 100.00% <100.00%> (ø)
src/Views/Traits/Helpers/FilterHelpers.php 97.26% <100.00%> (+0.15%) ⬆️

@lrljoe
v3 - Apply Reorder Sorting When Reordering (#1402)
429b54f 
* Fix for reorder sort not applying

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe lrljoe merged commit babe430 into v3-master Oct 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrljoe @rappasoft