Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev bleed #26

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Dev bleed #26

wants to merge 6 commits into from

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Mar 31, 2023

NOTE- This commit has a reference to dev-develop as it has most of the new features implemented for demonstration purposes

See comment below to discuss!

Core Updates

  • Local install of Alpine 3.0
  • Swap between filter Layout using top menu
  • Tailwind 3 (playground) implementation

Additional Changes to Component

  • Demonstration of setting filter values in configure() to reduce number of queries on refresh
  • All core filter types implemented (will migrate to tests in future)
  • Custom Filter Label Blade demonstrated
  • Custom Filter Pills Blade demonstrated
  • setFilterSlidedownRow demonstrated
  • setFilterSlidedownColspan demonstrated
  • Same filter in header/footer - demonstrating fix for "always visible" issue

@lrljoe
Copy link
Collaborator Author

lrljoe commented Mar 31, 2023

NOTE- This commit has a reference to dev-develop as it has most of the new features implemented for demonstration purposes

@rappasoft - Let me know what you think of this initial update please, if you're comfortable then my plan is to:

  1. Expand this demo a bit further to demonstrate some more of the package functionality
  2. Re-use the demo for the package tests so that its consistent, and any issues can quickly be spotted/tested in the real world
  3. Use the same instance in Dusk tests so that UX tests can run properly across the different themes & browsers

I think a demo branch for the core package "develop" would be useful, how would you like this named?

I'm not sure that matching develop for demo to develop on package would be the best route, but up to you!

@lrljoe lrljoe requested a review from rappasoft March 31, 2023 01:20
@rappasoft
Copy link
Owner

I'm good with modifying the demo in any way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants