This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
adding raven public DSN to the settings #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cromulus the only other reference I'm seeing for RAVEN_PUBLIC_DSN is rapidpro/rapidpro#669 which is also by you, when that merges and becomes available as a setting RapidPro I'm happy to see this merged. |
|
The Raven javascript library is installed here: However, it is left unconfigured because it it doens't have the public DNS to send error reports to, which in turn means that any error thrown in production gets squashed, making it far harder to debug. Yes, makes sense to hold off merging until the upstream rapidpro/rapidpro#669 is merged. Thanks! |
cromulus
pushed a commit
to cromulus/rapidpro-docker
that referenced
this pull request
Jul 13, 2019
…ng-compose-with-latest Add elasticsearch to docker compose
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we can configure the raven js library with the public DSN using an environment variable.