Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding the vulnerable version of bouncy castle in smbj #184

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

pwatson-r7
Copy link
Contributor

Description

Overriding the bouncycastle dependency bcprov-jdk18on in SMBJ as that version has vulnerabilities.
Bumped the version of commons-io to a version without vulnerabilities.

Motivation and Context

Explanation of why these changes are being proposed, including any links to other relevant issues or pull requests.

How Has This Been Tested?

Ran existing unit and integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@pwatson-r7 pwatson-r7 merged commit 56595c2 into master Nov 21, 2024
9 checks passed
@pwatson-r7 pwatson-r7 deleted the feature/update_vuln_bc branch November 21, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants