Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java Meterpreter Symlink Handling on Windows #731

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

zeroSteiner
Copy link
Contributor

This fixes issues in how the Java Meterpreter handles links and junctions when running on Windows. This issue arose when these tests failed due to the new addition of tests in rapid7/metasploit-framework#19554.

Along the way the following additional changes were made:

  • An issue with process execution was fixed whereby the subprocess did not have its working directory properly set.
  • pom.xml compatibility checks for Java 6 were updated to use javascript to select versioned files, so all files lacking a version and marked for version 1-6 are included. This means new versioned files can be added in the future without troubleshooting and updating this pom.xml.
  • Added version detection for Java 7 and 8.

For testing:

  • Grab the changes from PR 19554.
  • Start a Java Meterpreter session on a Windows host, make sure Java is version 8 or newer. Older versions will still fail and there's not much that can be done about that. Java 8 was released in 2014.
  • Run the tests and see them all work

@zeroSteiner zeroSteiner marked this pull request as draft November 6, 2024 22:20
@zeroSteiner zeroSteiner force-pushed the fix/met/java/symlinks branch 3 times, most recently from c267144 to af89b27 Compare November 8, 2024 15:32
@smcintyre-r7 smcintyre-r7 marked this pull request as ready for review November 8, 2024 15:39
@smcintyre-r7
Copy link
Contributor

This PR should be landed because the tests are passing in rapid7/metasploit-framework. Once this is landed, the Metasploit side of things should be laned after the last commit updating the testing definition is reverted:

rapid7/metasploit-framework@6274d04

@dledda-r7 dledda-r7 self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants