PQC: Add hybrid groups x25519/ML-KEM-768 and secp256r1/ML-KEM-768 #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FAlbertDev
approved these changes
Oct 16, 2024
|
Thanks for the reviews. I'm holding back on merging that because I'd like to update bogo (which I believe has test cases for those groups already). |
Merged
reneme
force-pushed
the
tls/ml_kem_hybrids
branch
from
c7a5ddf
to
9ebb11b
Compare
|
Enabling relevant BoGo tests revealed something that we might want to have a look at here (or independently): |
reneme
force-pushed
the
tls/ml_kem_hybrids
branch
from
9ebb11b
to
c85054a
Compare
reneme
force-pushed
the
tls/ml_kem_hybrids
branch
from
c85054a
to
88ef044
Compare
Those groups are described in draft-kwiatkowski-tls-ecdhe-mlkem and the code points are officially provided by IANA. Therefore they can be seen as 'fit for production use'.
reneme
force-pushed
the
tls/ml_kem_hybrids
branch
from
88ef044
to
59abd7a
Compare
reneme
commented
Oct 17, 2024
Comment on lines
1008
to
1014
| // TODO: once `TLS::Policy::key_exchange_groups()` contains it by | ||
| // default, remove this explicit check. | ||
| if(group == Botan::TLS::Group_Params::HYBRID_X25519_KYBER_768_R3_OQS) { | ||
| // | ||
| // See: https://github.com/randombit/botan/pull/4305 | ||
| if(group == Botan::TLS::Group_Params::HYBRID_X25519_ML_KEM_768) { | ||
| groups.push_back(group); | ||
| } |
There was a problem hiding this comment.
See also: #4305 (comment)
|
Should be ready for merge now. |
randombit
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Dependencies
Description
Those groups are described in draft-kwiatkowski-tls-ecdhe-mlkem and the code points are registered by IANA.