-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Menu (Buttons & Rotary Input) #498
base: master
Are you sure you want to change the base?
Conversation
While I actually prefer MonoMenu to LCDMenuLib2 the rotary encoder should work before we think about merging this. Anyway, looks very promising! |
@fiendie duplication in the pinmapping.h wasn't intended, maybe I forgot to remove the other ones or it happened when I merged the latest changes from the master. But the renaming was, since it's with this menu no longer restricted to a rotary encoder I thought calling the pins PIN_ROTARY_XXX is a bit misleading. Okay, I'll try to add the encoder too ;) |
Now also with (basic) support for the rotary encoder. |
…added visible logic
Updated MonoMenu version.
just wanted to rebase your PR to current master, so i could give it a try on my mashine. |
@@ -1644,6 +1646,10 @@ void setup() { | |||
u8g2_prepare(); | |||
displayLogo(String("Version "), String(sysVersion)); | |||
delay(2000); // caused crash with wifi manager on esp8266, should be ok on esp32 | |||
|
|||
#if FEATURE_MENU == 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you could be more specific with the naming:
-> FEATURE_DISPLAY_MENU
-> displayMenuHandler
Oh... sorry, hadn't looked into this stuff for a while. Life came up with some other 'distractions'... I'll check the latest (timer) changes and the status of my lib if everything works with the rotary encoder now (can't remember ^^') and then get back to you soon. |
I started to make the menu from @FabianSperrle working again and since I wasn't really happy with the used menu library I got carried away and worked on a new one. (It's currently only used with clevercoffee - will make it more flexible in the future)
The menu is capable to set (most) parameters without using the website.
If used with buttons as input the buttons use the same pins as 'reserved' for the rotary encoder, so the menu is controlled with three buttons (up, down, enter)
Depending on the activated features, more or less options are visible.
For example, Brew Time & Weight, Preinfusion and the Maintenance Item (currently only contains Backflush) are only visible if
BREWCONTROL_TYPE > 0
etc.The menu uses https://github.com/craftmetrics/esp32-button for button press detection and debouncing.
Activate
To enable the Menu, set
FEATURE_MENU
to1
in the userConfig.hMENU_INPUT
supportsMENUINPUT::BUTTONS
andMENUINPUT::ROTARY
Menu Structure
Available Menu Items are at the moment:
Menu Control
Back
orClose Menu
Since I don't have a 'full expansion' yet, I couldn't test everything...
So, let me know what you guys think... (I'm also in the Discord under the name Kuraiko)
PS: It most certainly won't work with the vertical display