Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivy recommended hardening #329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −3
Open

Trivy recommended hardening #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions deploy/chart/local-path-provisioner/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,10 @@ podAnnotations: {}
podSecurityContext: {}
# runAsNonRoot: true

securityContext: {}
securityContext:
seccompProfile:
type: RuntimeDefault
Comment on lines +100 to +102
Copy link
Member

@derekbit derekbit Aug 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we need to enable it by default. Or, users can enable it if they need it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would aim for by default and have folks loosen the security restrictions if they can't run with them.

# allowPrivilegeEscalation: false
# seccompProfile:
# type: RuntimeDefault
# capabilities:
# drop: ["ALL"]
# runAsUser: 65534
Expand Down
3 changes: 3 additions & 0 deletions deploy/local-path-storage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ spec:
fieldPath: metadata.namespace
- name: CONFIG_MOUNT_PATH
value: /etc/config/
securityContext:
seccompProfile:
type: RuntimeDefau
volumes:
- name: config-volume
configMap:
Expand Down
3 changes: 3 additions & 0 deletions deploy/provisioner.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
securityContext:
seccompProfile:
type: RuntimeDefault
volumes:
- name: config-volume
configMap:
Expand Down