Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker v26.1.4, v27.0.1, v27.0.2, v27.0.3, v27.1.0, v27.1.1 #150

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Add docker v26.1.4, v27.0.1, v27.0.2, v27.0.3, v27.1.0, v27.1.1 #150

merged 1 commit into from
Aug 28, 2024

Conversation

chiukapoor
Copy link
Contributor

@chiukapoor chiukapoor commented Jul 25, 2024 •
edited
Loading

Updates

  • Add docker v26.1.4, v27.0.1, v27.0.2, v27.0.3, v27.1.0, v27.1.1
  • Replace centos repo with RHEL
  • Remove custom code for release version 7
  • Update RHEL to 9.4
  • Add 26.1.x in excluded versions
  • Replace centos repo with RHEL

Issue

@chiukapoor chiukapoor requested a review from a team as a code owner July 25, 2024 10:06
@chiukapoor chiukapoor marked this pull request as draft July 25, 2024 13:48
@chiukapoor chiukapoor force-pushed the add-v27 branch 2 times, most recently from 3e2b9bb to 2193dfc Compare July 25, 2024 13:56
@chiukapoor chiukapoor changed the title Add docker v26.1.4, v27.0.1, v27.0.2, v27.0.3 Add docker v26.1.4, v26.1.5, v27.0.1, v27.0.2, v27.0.3, v27.1.0, v27.1.1 Jul 25, 2024
@chiukapoor chiukapoor marked this pull request as ready for review August 2, 2024 04:44
@chiukapoor chiukapoor changed the title Add docker v26.1.4, v26.1.5, v27.0.1, v27.0.2, v27.0.3, v27.1.0, v27.1.1 Add docker v26.1.4, v27.0.1, v27.0.2, v27.0.3, v27.1.0, v27.1.1 Aug 2, 2024
@chiukapoor chiukapoor force-pushed the add-v27 branch 3 times, most recently from be6d5f0 to a384995 Compare August 2, 2024 16:44
@chiukapoor
chore: Add docker v26.1.4, v27.0.1, v27.0.2, v27.0.3, v27.1.0, v27.1.1
8897503 
* Replace centos repo with RHEL
* Remove custom code for release version 7
* Update RHEL to 9.4
* Add 26.1.x in excluded versions
kinarashah
kinarashah requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@kinarashah kinarashah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted one question and would be also best to split commits into 2:

  • one removes centos for all versions
  • adding new versions

.github/workflows/add_new_versions.yml
@@ -33,7 +33,7 @@ jobs:
run: |
python -u workflow_scripts/check-for-new-versions.py
env:
EXCLUDED_VERSIONS: "v20.10.x,v23.0.x"
EXCLUDED_VERSIONS: "v20.10.x,v23.0.x,v26.1.x"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding only v26.1.x and not v26.0.x?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there was a release for 26.1.5 https://github.com/moby/moby/releases/tag/v26.1.5, but there were no packages uploaded for the same at https://download.docker.com/linux/rhel/9/x86_64/stable/Packages/

workflow_scripts/check-for-new-versions.py
@@ -3,7 +3,7 @@

# Constants
DIST_FOLDER = './dist'
EXCLUDED_VERSIONS = os.environ.get('EXCLUDED_VERSIONS', 'v20.10.x,v23.0.x')
EXCLUDED_VERSIONS = os.environ.get('EXCLUDED_VERSIONS', 'v20.10.x,v23.0.x,v26.1.x')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there was a release for 26.1.5 https://github.com/moby/moby/releases/tag/v26.1.5, but there were no packages uploaded for the same at https://download.docker.com/linux/rhel/9/x86_64/stable/Packages/

@kinarashah kinarashah merged commit dc1aa12 into rancher:master Aug 28, 2024
3 checks passed
@chiukapoor chiukapoor mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitulshah-suse mitulshah-suse mitulshah-suse left review comments

@kinarashah kinarashah kinarashah approved these changes

@jiaqiluo jiaqiluo Awaiting requested review from jiaqiluo

@snasovich snasovich Awaiting requested review from snasovich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chiukapoor @kinarashah @mitulshah-suse