Merge pull request #5 from ralf-ueberfuhr-ars/feature/rename-birthdate

Rename birthdate to birth_date.
ralf-ueberfuhr-ars · Jun 18, 2024 · 3020a03 · 3020a03
2 parents f481fda + 483b013
commit 3020a03
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/customer-api-provider/src/main/java/de/schulung/sample/quarkus/Customer.java b/customer-api-provider/src/main/java/de/schulung/sample/quarkus/Customer.java
@@ -1,5 +1,6 @@
 package de.schulung.sample.quarkus;
 
+import jakarta.json.bind.annotation.JsonbProperty;
 import jakarta.json.bind.annotation.JsonbTransient;
 import lombok.AllArgsConstructor;
 import lombok.Getter;
@@ -19,7 +20,8 @@ public class Customer {
   @Setter(onMethod_ = @JsonbTransient)
   private UUID uuid;
   private String name;
-  private LocalDate birthdate; // TODO birth_date?
+  @JsonbProperty("birth_date") // TODO -> use snake_case globally?
+  private LocalDate birthdate;
   private String state;
 
 }
diff --git a/customer-api-provider/src/test/java/de/schulung/sample/quarkus/CustomerApiTests.java b/customer-api-provider/src/test/java/de/schulung/sample/quarkus/CustomerApiTests.java
@@ -64,7 +64,7 @@ void shouldCreateCustomer() {
         .body("""
                 {
                     "name": "Tom",
-                    "birthdate": "2000-10-04",
+                    "birth_date": "2000-10-04",
                     "state": "active"
                 }
                 """)
@@ -76,7 +76,7 @@ void shouldCreateCustomer() {
         .header("Location", startsWith("http"))
         .contentType(ContentType.JSON)
         .body("name", is(equalTo("Tom")))
-        .body("birthdate", is(equalTo("2000-10-04")))
+        .body("birth_date", is(equalTo("2000-10-04")))
         .body("uuid", is(notNullValue()))
         .extract()
         .header("Location");
@@ -88,7 +88,7 @@ void shouldCreateCustomer() {
         .then()
         .statusCode(200)
         .body("name", is(equalTo("Tom")))
-        .body("birthdate", is(equalTo("2000-10-04")));
+        .body("birth_date", is(equalTo("2000-10-04")));
     }
 
   }

diff --git a/openapi.yml b/openapi.yml
@@ -246,7 +246,7 @@ components:
         - disabled
     Customer:
       required:
-        - birthdate
+        - birth_date
         - name
       type: object
       properties:
@@ -259,7 +259,7 @@ components:
           maxLength: 100
           type: string
           example: Tom Mayer
-        birthdate:
+        birth_date:
           type: string
           format: date
         state: