-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update endpoint without primary for images #35 #75
base: develop
Are you sure you want to change the base?
Add update endpoint without primary for images #35 #75
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #75 +/- ##
===========================================
+ Coverage 98.59% 98.88% +0.28%
===========================================
Files 21 21
Lines 428 447 +19
===========================================
+ Hits 422 442 +20
+ Misses 6 5 -1 ☔ View full report in Codecov by Sentry. |
…t-without-primary-for-images-#35
@asuresh-code Could you please resolve the conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments, mainly on grammar and confusion
Discussed with Anikesh in person. The actual topic here is when adding extra info to the request body, such as "id" or even a made up field, it gets included in the Curl response, but then these extra fields don't get expected or returned in the response body, and a 200 status code is returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
see #35
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #35