Address further comments #11

ral-facilities · Sep 30, 2024 · d8b5294 · d8b5294
1 parent 9efe4a3
commit d8b5294
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/object_storage_api/core/config.py b/object_storage_api/core/config.py
@@ -45,7 +45,7 @@ class ObjectStorageConfig(BaseModel):
     access_key: SecretStr
     secret_access_key: SecretStr
     bucket_name: SecretStr
-    presigned_url_expiry: int
+    presigned_url_expiry_seconds: int
 
     model_config = ConfigDict(hide_input_in_errors=True)
 

diff --git a/test/e2e/conftest.py b/test/e2e/conftest.py
@@ -30,7 +30,7 @@ def fixture_cleanup_database_collections():
     database.attachments.delete_many({})
 
 
-@pytest.fixture(name="create_and_cleanup_object_storage_bucket", autouse=True)
+@pytest.fixture(name="cleanup_object_storage_bucket", autouse=True)
 def fixture_cleanup_object_storage_bucket():
     """
     Fixture to clean up the test object storage bucket after session finishes.

diff --git a/test/pytest.ini b/test/pytest.ini
@@ -18,4 +18,4 @@ env =
     OBJECT_STORAGE__ACCESS_KEY=root
     OBJECT_STORAGE__SECRET_ACCESS_KEY=example_password
     OBJECT_STORAGE__BUCKET_NAME=test-object-storage
-    OBJECT_STORAGE__PRESIGNED_URL_EXPIRY=1800
+    OBJECT_STORAGE__PRESIGNED_URL_EXPIRY_SECONDS=1800