Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload pasted image on editor #495

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Upload pasted image on editor #495

wants to merge 17 commits into from

Conversation

mhanoglu
Copy link

No description provided.

@bennothommo bennothommo added Status: Review Needed Requires review from a maintainer or trusted community member Type: Enhancement Proposed enhancement that has been accepted / implemented labels Mar 29, 2020
bennothommo
bennothommo suggested changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@bennothommo bennothommo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marzochi Some code cleanup required before we can review and potentially merge this.

assets/js/post-form.js Outdated Show resolved Hide resolved
assets/js/post-form.js Show resolved Hide resolved
assets/js/post-form.js Outdated Show resolved Hide resolved
assets/js/post-form.js Show resolved Hide resolved
assets/js/post-form.js Show resolved Hide resolved
formwidgets/BlogMarkdown.php Outdated Show resolved Hide resolved
formwidgets/BlogMarkdown.php Outdated Show resolved Hide resolved
formwidgets/BlogMarkdown.php Outdated Show resolved Hide resolved
assets/js/post-form.js Outdated Show resolved Hide resolved
assets/js/post-form.js Outdated Show resolved Hide resolved
mhanoglu and others added 14 commits March 29, 2020 17:33
@mhanoglu
Update assets/js/post-form.js
9763945 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update assets/js/post-form.js
2663122 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update assets/js/post-form.js
9b87ac9 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update assets/js/post-form.js
d616624 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update assets/js/post-form.js
ee76059 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update formwidgets/BlogMarkdown.php
0cea8d5 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update formwidgets/BlogMarkdown.php
293eb81 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update formwidgets/BlogMarkdown.php
aa3a151 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update assets/js/post-form.js
a4b6a5e 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update assets/js/post-form.js
dc3e509 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update formwidgets/BlogMarkdown.php
3c90ab6 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update formwidgets/BlogMarkdown.php
ffa66fa 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update formwidgets/BlogMarkdown.php
d8e238e 
Co-Authored-By: Ben Thomson <[email protected]>
@mhanoglu
Update formwidgets/BlogMarkdown.php
9dcde14 
Co-Authored-By: Ben Thomson <[email protected]>
mhanoglu
mhanoglu commented Mar 29, 2020
View reviewed changes
Copy link
Author

@mhanoglu mhanoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@bennothommo
Copy link
Contributor

@marzochi Thanks for making those changes - just make sure to do the following as well:
#495 (comment)

@mhanoglu
Copy link
Author

Thanks again, I removed unnecessary codes. I hope it'll be passed :)

@mhanoglu mhanoglu requested a review from bennothommo March 29, 2020 15:20
@bennothommo bennothommo self-assigned this Nov 19, 2020
@bennothommo bennothommo added Status: Testing Needed Requires testing before it can be accepted and removed Status: Review Needed Requires review from a maintainer or trusted community member labels Nov 19, 2020
@bennothommo bennothommo added this to the v1.4.4 milestone Nov 19, 2020
@daftspunk daftspunk requested review from daftspunk and removed request for bennothommo April 5, 2021 04:07
@daftspunk daftspunk assigned daftspunk and unassigned bennothommo Apr 5, 2021
@daftspunk
Copy link
Member

Very cool @mhanoglu. Added a note to review this and implement into the core widget

Thanks!

@daftspunk daftspunk removed this from the v1.4.4 milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennothommo bennothommo bennothommo requested changes

@daftspunk daftspunk Awaiting requested review from daftspunk

Assignees

@daftspunk daftspunk

Labels
Status: Testing Needed Requires testing before it can be accepted Type: Enhancement Proposed enhancement that has been accepted / implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhanoglu @bennothommo @daftspunk