fix: usage of layoutSize.value doesn't contain width or height causin… #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
ChartPath
doesn't render sometimes becauselayoutSize
is initialized as 0 onChartContext
and is not being updated, causing all values multiplied by eitherlayoutSize.value.width
orlayoutSize.value.height
to be equal toNaN
.In addition, the path created using
useDerivedValue
is running on another thread and is not picking up the update onlayoutSize
when the following block runs :Solution:
Initialize
width
andheight
onChartPathProvider
and set it to either the values that are being passed as props or the ones onlayoutSize.value
. Use these values for all calculations to make sure nothing is being multiplied by an undefined value.On ChartPath, use
width
andheight
from props instead of setting these onlayoutSize
using anuseEffect
to preventuseDerivedValue
from using any stale values. Also added[currData.value, prevData.value, smoothingStrategy.value, width, height]
as dependencies when callinguseDerivedValue
to avoid further use of stale data.