Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): Add hotkey nav, tweak UI slightly for better clarity between results #255

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

half0wl
Copy link
Member

@half0wl half0wl commented Apr 27, 2023

This adds back hotkey-based nav in the search UI:

  • Arrow keys (^, v) to navigate through results
  • Enter to browse to selected result
  • Hover to select result

UI tweaks:

  • Make results stand out more by adding borders
  • Clip text overflow for long sections, e.g.
    ss 2023-04-28 at 3 10 19 AM

Demo

ss.2023-04-28.at.3.08.35.AM.mov

Resolves #247
Resolves LOG-351

@linear
Copy link

linear bot commented Apr 27, 2023

@railway-app
Copy link

railway-app bot commented Apr 27, 2023

This PR is being deployed to Railway 🚅

📚 railway docs: ◻️ REMOVED

src/components/Search/Results.tsx Show resolved Hide resolved
src/components/Search/Results.tsx Show resolved Hide resolved
src/components/Search/Results.tsx Show resolved Hide resolved
src/components/Search/Results.tsx Show resolved Hide resolved
@half0wl half0wl requested a review from ndneighbor April 27, 2023 19:14
Copy link
Contributor

@ndneighbor ndneighbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really solid work, really appreciate the fast turnaround on this.

Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a application error when pressing cmd+k in the preview

image

@half0wl half0wl merged commit b719824 into main Apr 27, 2023
@half0wl half0wl deleted the feat/search-hotkeys branch April 27, 2023 19:50
@half0wl half0wl added feature New feature or request ui/ux labels Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request ui/ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hotkey nav to Search UI
3 participants