This repository has been archived by the owner on Aug 17, 2017. It is now read-only.
Add possibility to trust a parameter branch #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a way to mark a specific branch of the parameter hash as trusted. Using the added `StrongParameters::ANY` or `:*` allows to mark a value of the hash respectively. This functionality can be handy when your controllers already rely on strong_parameters and raising of errors is enabled. If the parameter hash contains in such a case a parameter value which is completely customizable by the consumer of the controller, it might be impossible to predefine keys.
sdepold
force-pushed
the
feature/non-scalar-trusted-keys
branch
from
dcf02b8 to
f4bf58e
Compare
|
Would be very useful, nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a way to mark a specific branch of the parameter
hash as trusted. Using the added
StrongParameters::ANYor:*allowsto mark a value of the hash respectively.
This functionality can be handy when your controllers already rely on
strong_parameters and raising of errors is enabled. If the parameter
hash contains in such a case a parameter value which is completely
customizable by the consumer of the controller, it might be impossible
to predefine keys.
Relates to rails/rails#9454