This repository has been archived by the owner on Aug 17, 2017. It is now read-only.
test, not raise against NEVER_UNPERMITTED_PARAMS #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test checking that any param included in Parameters::NEVER_UNPERMITTED_PARAMS will not raise an error even if not explicitly permitted.
| }) | ||
|
|
||
| assert_nothing_raised(ActionController::UnpermittedParameters) do |
There was a problem hiding this comment.
You don't need to pass the exception.
`Array.sample` not supported in ruby 1.8.7 (with Gemfile.rails-3.0x ) so switched to using `index[0]`
the comment wouldn't have stayed in sync with code changes.
levsero
changed the title
| key = ActionController::Parameters::NEVER_UNPERMITTED_PARAMS[0] | ||
| params = ActionController::Parameters.new({ | ||
| key => "Turnips" |
There was a problem hiding this comment.
It's better to test each entries of the NEVER_UNPERMITTED_PARAMS array. isn't it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test checking that any param included in Parameters::NEVER_UNPERMITTED_PARAMS will not raise an error even if not explicitly permitted.