This repository has been archived by the owner on Aug 17, 2017. It is now read-only.
Change readme code examples to be more explicit #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating readme to show the two different examples more explicitly. The previous code example was confusing to me.
| @@ -31,6 +31,7 @@ class PeopleController < ActionController::Base | |||
| end | |||
| end | |||
| ``` | |||
| This will pass with flying colors as long as there's a person key in the parameters, otherwise it'll raise a ActionController::MissingParameter exception, which will get caught by ActionController::Base and turned into that 400 Bad Request reply. | |||
There was a problem hiding this comment.
It should be ActionController::ParameterMissing instead.
I believe mine #158 can be closed when your pull request is merged.
There was a problem hiding this comment.
Language could, perhaps, be a little less flowery.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating readme to show the two different examples more explicitly. The previous code example was confusing to me.