Explicitly set the user to vscode in the Ruby image Dockerfile #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Since the metadata from devcontainer.json is not present in the image, other Dev Container implementations will not set this user (which is default for vscode and created by the debian base image). So lets explicitly set it so that those Dev Container implementations use the right user when using this image.
andrewn617
force-pushed
the
explicitly-set-user
branch
from
5ffbbb9
to
4c9d4f3
Compare
viktorianer
reviewed
Oct 3, 2024
| && apt-get purge -y imagemagick imagemagick-6-common | ||
|
|
||
| USER vscode |
There was a problem hiding this comment.
Could we now remove the comment "remoteUser": "root", from https://github.com/rails/rails/blob/ced86070009881362446b5dbbaa36bde36c64b6a/railties/lib/rails/generators/rails/devcontainer/templates/devcontainer/devcontainer.json.tt#L27?
I think so. 🔢
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the metadata from devcontainer.json is not present in the image, other Dev Container implementations will not set this user (which is default for vscode and created by the debian base image). So lets explicitly set it so that those Dev Container implementations use the right user when using this image.