-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bigdecimal
as a dependency
#561
Add bigdecimal
as a dependency
#561
Conversation
e90967d
to
f399763
Compare
will check somewhere this weekend what is needed to get the Windows pipeline running. |
2a9b291
to
d8e1e3b
Compare
The tests on Windows work now again: Instead of using |
This seems weird, can you explain more what that's about? Also, I don't understand why we need a ci step to install bigdecimal manually if it's listed in the gemspec. Why wouldn't the normal |
d8e1e3b
to
89aa640
Compare
Good point,
I think |
This is to address the following warning on Ruby 3.3: ``` /home/apf/dev/rails-sqlserver/tiny_tds/lib/tiny_tds.rb:3: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. ```
89aa640
to
a9c5d88
Compare
This is to address the following warning on Ruby 3.3: