Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bigdecimal as a dependency #561

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

andyundso
Copy link
Member

This is to address the following warning on Ruby 3.3:

/home/apf/dev/rails-sqlserver/tiny_tds/lib/tiny_tds.rb:3: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec.

@andyundso andyundso requested a review from aharpervc July 12, 2024 20:05
@andyundso andyundso force-pushed the bigdecimal-dependency branch from e90967d to f399763 Compare July 12, 2024 20:32
@andyundso
Copy link
Member Author

will check somewhere this weekend what is needed to get the Windows pipeline running.

@andyundso andyundso removed the request for review from aharpervc July 13, 2024 09:04
@andyundso andyundso force-pushed the bigdecimal-dependency branch 3 times, most recently from 2a9b291 to d8e1e3b Compare July 16, 2024 20:45
@andyundso
Copy link
Member Author

The tests on Windows work now again: Instead of using gem install into a temporary directory as we did before, I now use gem unpack to extract the gem.

@andyundso andyundso requested a review from aharpervc July 16, 2024 20:58
@aharpervc
Copy link
Contributor

The tests on Windows work now again: Instead of using gem install into a temporary directory as we did before, I now use gem unpack to extract the gem.

This seems weird, can you explain more what that's about? Also, I don't understand why we need a ci step to install bigdecimal manually if it's listed in the gemspec. Why wouldn't the normal gem install tiny_tds process bring in that new dependency?

@andyundso andyundso force-pushed the bigdecimal-dependency branch from d8e1e3b to 89aa640 Compare July 17, 2024 21:01
@andyundso
Copy link
Member Author

Also, I don't understand why we need a ci step to install bigdecimal manually if it's listed in the gemspec. Why wouldn't the normal gem install tiny_tds process bring in that new dependency?

Good point, gem install should actually do that. I checked and most of our gem install commands used --local, which restricted the gem to download anything from the internet. This is removed now in the latest commit and the additional step to install bigdecimal is no longer required.

This seems weird, can you explain more what that's about?

I think gem unpack is a more elegant solution to solve what we want to do, which is to extract the compiled files from the built gem.

This is to address the following warning on Ruby 3.3:

```
/home/apf/dev/rails-sqlserver/tiny_tds/lib/tiny_tds.rb:3: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec.
```
@andyundso andyundso force-pushed the bigdecimal-dependency branch from 89aa640 to a9c5d88 Compare October 22, 2024 19:16
@andyundso andyundso merged commit bb1d8ae into rails-sqlserver:master Oct 23, 2024
44 checks passed
@andyundso andyundso deleted the bigdecimal-dependency branch October 23, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants