Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary basic columns should be limitable #1249

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Oct 17, 2024

Binary basic columns should be limitable. So if you have a migration:

create_table "test_table", id: false do |t|
  t.binary_basic "test_col", limit: 16
end

The test_col column should be of type binary_basic(16). Before it was being set to binary_basic(1).

Fixes issue #1248

@aidanharan aidanharan changed the title Basic binary limit Binary basic columns should be limitable Oct 22, 2024
@aidanharan aidanharan marked this pull request as ready for review October 22, 2024 13:36
@aidanharan aidanharan merged commit 8bf060f into main Oct 22, 2024
2 of 4 checks passed
@aidanharan aidanharan deleted the binary_basic_limit branch October 22, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant