Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow INSERT statements with SELECT notation #1238

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Allow INSERT statements with SELECT notation #1238

merged 2 commits into from
Oct 9, 2024

Conversation

zurchpet
Copy link
Contributor

@zurchpet zurchpet commented Oct 7, 2024

This Pull request fixes #1237

@zurchpet zurchpet mentioned this pull request Oct 7, 2024
Closed
@aidanharan
Copy link
Contributor

@zurchpet The CI tests are failing. Tests will need to pass before I can merge the PR.

The failing ActiveRecord::PredicateBuilderTest tests can be ignored as they have already been fixed in main by #1239

@aidanharan aidanharan changed the title fix: allow INSERT statements with SELECT notation Allow INSERT statements with SELECT notation Oct 9, 2024
@aidanharan aidanharan merged commit 68d1c0f into rails-sqlserver:main Oct 9, 2024
3 checks passed
@aidanharan
Copy link
Contributor

@zurchpet Thanks for the PR. Do you need the change back ported to version 7.2?

@zurchpet
Copy link
Contributor Author

@aidanharan Thanks a lot!
Yes. Also in 7.1 actually.
We pin to version 7.1.4 for now.
Rails 7.2 or Rails 8.0 Upgrade is still in planing.

This was referenced Oct 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug introduced by PR #1206 (allow spaces in table names)
2 participants
@zurchpet @aidanharan