Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-dbo schemas in schema dumper #1201

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Support non-dbo schemas in schema dumper #1201

merged 9 commits into from
Jul 16, 2024

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Jul 5, 2024 •
edited
Loading

SQL Server supports databases having multiple schemas.

Previously the dumper:

  • Didn't generate the code to generate the schemas.
  • Only generated the code to create the tables within the "dbo" schema.

This PR will get the dumper to:

  • Generate the code to generate the non "dbo" schemas.
  • Generates the code to generate the tabes in all schema. The schema will only be included in tables that are not in the "dbo" schema.

Fixes issue #1155 for Rails 7.2

@aidanharan aidanharan changed the title Support non-dbo schemas in dumper Support non-dbo schemas in schema dumper Jul 15, 2024
@aidanharan aidanharan marked this pull request as ready for review July 16, 2024 13:46
@aidanharan aidanharan merged commit 0b61b94 into main Jul 16, 2024
5 checks passed
@aidanharan aidanharan deleted the dumper-non-dbo-table-schemas branch July 16, 2024 13:48
aidanharan added a commit that referenced this pull request Jul 16, 2024
@aidanharan
Support non-dbo schemas in schema dumper (#1201)
d361c49
@jvon1904 jvon1904 mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan