You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ActiveRecord::Relation#calculate patch was introduced by #1090 to fix an issue with failing activerecord/test/cases/null_relation_test.rb tests. Not sure exactly what tests now and since the tests pass now without the patch then all good 👍
@jonahgeorge The main branch is used for Rails 7.2 development. Do you need the patch removed from the 7.1 adapter?
The ActiveRecord::Relation#calculate patch was introduced by #1090 to fix an issue with failing activerecord/test/cases/null_relation_test.rb tests. Not sure exactly what tests now and since the tests pass now without the patch then all good 👍
@jonahgeorge The main branch is used for Rails 7.2 development. Do you need the patch removed from the 7.1 adapter?
Would you accept backports for both 7.1 and 7.0? Unfortunately the app that I really need this in is still on 7.0-- No worries if not
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all,
I've been working on adding SQL Server support to ankane/groupdate and discovered that this patch of
ActiveRecord::Relation#calculateis interfering with the library's own patching of the same method.It appears that all tests pass without this patch so posting this PR to potential remove it as I don't fully follow why it was introduced to start.