Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update-all for composite key #1189

Merged
merged 9 commits into from
Jun 8, 2024
Merged

Fix update-all for composite key #1189

merged 9 commits into from
Jun 8, 2024

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented May 29, 2024

Fix:

  • UpdateAllTest#test_update_all_composite_model_with_join_subquery
  • DeleteAllTest#test_delete_all_composite_model_with_join_subquery

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/9229223643/job/25394973176

1) Error:
UpdateAllTest#test_update_all_composite_model_with_join_subquery:
ActiveRecord::StatementInvalid: TinyTds::Error: An expression of non-boolean type specified in a context where a condition is expected, near ','.
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:440:in `each'

  3) Error:
DeleteAllTest#test_delete_all_composite_model_with_join_subquery:
ActiveRecord::StatementInvalid: TinyTds::Error: An expression of non-boolean type specified in a context where a condition is expected, near ','.
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:440:in `each'
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:440:in `handle_to_names_and_values'

Related: rails/rails#49655

@aidanharan aidanharan marked this pull request as ready for review June 8, 2024 17:09
@aidanharan aidanharan merged commit 331ca6b into main Jun 8, 2024
2 of 8 checks passed
@aidanharan aidanharan deleted the update-all-composite-key branch June 8, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant