Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redefined method warnings #1123

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix redefined method warnings #1123

merged 1 commit into from
Oct 19, 2023

Conversation

aidanharan
Copy link
Contributor

Fix the redefined method warnings when running the test suite.

Examples:

/vagrant/activerecord-sqlserver-adapter/test/cases/coerced_tests.rb:2564: warning: method redefined; discarding old invalid_add_column_option_exception_message
/vagrant/rails/activerecord/test/cases/migration/invalid_options_test.rb:10: warning: previous definition of invalid_add_column_option_exception_message was here
/vagrant/activerecord-sqlserver-adapter/test/cases/coerced_tests.rb:2576: warning: method redefined; discarding old thread_encrypting_and_decrypting
/vagrant/rails/activerecord/test/cases/encryption/concurrency_test.rb:15: warning: previous definition of thread_encrypting_and_decrypting was here
/vagrant/activerecord-sqlserver-adapter/test/cases/coerced_tests.rb:2593: warning: method redefined; discarding old serializer
/vagrant/rails/activerecord/test/cases/message_pack_test.rb:80: warning: previous definition of serializer was here

@aidanharan aidanharan marked this pull request as ready for review October 19, 2023 11:12
@aidanharan aidanharan merged commit a923a68 into main Oct 19, 2023
5 of 8 checks passed
@aidanharan aidanharan deleted the undefined-method-warning branch October 19, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant