Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique attribute of IndexDefinition should be a boolean #1098

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Unique attribute of IndexDefinition should be a boolean #1098

merged 1 commit into from
Sep 27, 2023

Conversation

aidanharan
Copy link
Contributor

The unique attribute of IndexDefinition should be a boolean.

Fixes ActiveRecord::Migration::ReferencesStatementsTest#test_creates_named_unique_index test.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/6328689792/job/17187421431

ActiveRecord::Migration::ReferencesStatementsTest#test_creates_named_unique_index [/usr/local/bundle/bundler/gems/rails-6797c7382e37/activerecord/test/cases/migration/references_statements_test.rb:82]:
Expected false to be truthy.

bin/rails test /usr/local/bundle/bundler/gems/rails-6797c7382e37/activerecord/test/cases/migration/references_statements_test.rb:80

@aidanharan aidanharan changed the title Unique is expected to be a boolean Uunique attribute of IndexDefinition should be a boolean Sep 27, 2023
@aidanharan aidanharan changed the title Uunique attribute of IndexDefinition should be a boolean Unique attribute of IndexDefinition should be a boolean Sep 27, 2023
@aidanharan aidanharan marked this pull request as ready for review September 27, 2023 21:03
@aidanharan aidanharan merged commit ed474fb into main Sep 27, 2023
0 of 8 checks passed
@aidanharan aidanharan deleted the indexes-unique-boolean branch September 27, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan