Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for USE clause #1091

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fixes for USE clause #1091

merged 1 commit into from
Sep 20, 2023

Conversation

aidanharan
Copy link
Contributor

Fixes for the USE clause.

  • USE queries should not be regarded as write queries.
  • USE queries should be marked as schema type queries.

Changes reduced the number of failing bundle exec rake test TEST_FILES_AR="test/cases/query_cache_test.rb" tests.

Before

55 runs, 169 assertions, 6 failures, 2 errors, 2 skips

After

55 runs, 173 assertions, 5 failures, 0 errors, 2 skips

@aidanharan aidanharan changed the title Fixes for use clause Fixes for USE clause Sep 20, 2023
@aidanharan aidanharan marked this pull request as ready for review September 20, 2023 13:30
@aidanharan aidanharan merged commit 1d278ff into main Sep 20, 2023
0 of 8 checks passed
@aidanharan aidanharan deleted the use-clause branch September 20, 2023 13:30
lavika pushed a commit to lavika/activerecord-sqlserver-adapter that referenced this pull request Sep 26, 2023
@aidanharan
Fixes for use clause (rails-sqlserver#1091)
d93475f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan