Skip to content

Commit

Permalink
Enable identity insert on view's base table
Browse files Browse the repository at this point in the history
  • Loading branch information
aidanharan committed Oct 1, 2024
1 parent a2f2290 commit 86655aa
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 0 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#### Unreleased

#### Fixed

- [#1231](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1231) Enable identity insert on view's base table

## v7.1.7

#### Fixed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ def internal_exec_query(sql, name = "SQL", binds = [], prepare: false, async: fa
log(sql, name, binds, async: async) do
with_raw_connection do |conn|
if id_insert_table_name = query_requires_identity_insert?(sql)
# If the table name is a view, we need to get the base table name for enabling identity insert.
id_insert_table_name = view_table_name(id_insert_table_name) if view_exists?(id_insert_table_name)

with_identity_insert_enabled(id_insert_table_name, conn) do
result = internal_exec_sql_query(sql, conn)
end
Expand Down
8 changes: 8 additions & 0 deletions test/cases/view_test_sqlserver.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,12 @@ class ViewTestSQLServer < ActiveRecord::TestCase
assert_equal 1, klass.count
end
end

describe 'identity insert' do
it "identity insert works with views" do
assert_difference("SSTestCustomersView.count", 1) do
SSTestCustomersView.create!(id: 5, name: "Bob")
end
end
end
end

0 comments on commit 86655aa

Please sign in to comment.