Enabled warnings to be treated as errors

[BREAKING] DropDownDataGrid SearchText renamed to SearchTextPlaceholder

Radzen.Blazor/Common.cs

@@ -2961,9 +2961,18 @@ private static string GetByteString(uint x)
         }
     }
 
+    /// <summary>
+    /// CoordinateSystem enum
+    /// </summary>
     public enum CoordinateSystem
     {
+        /// <summary>
+        /// Cartesian CoordinateSystem
+        /// </summary>
         Cartesian,
+        /// <summary>
+        /// Cartesian CoordinateSystem
+        /// </summary>
         Polar
     }
 }

Radzen.Blazor/DropDownBase.cs

@@ -780,14 +780,14 @@ internal virtual async System.Threading.Tasks.Task<LoadDataArgs> GetLoadDataArgs
 #if NET5_0_OR_GREATER
             if (AllowVirtualization)
             {
-                return new Radzen.LoadDataArgs() { Skip = 0, Top = PageSize, Filter = searchText };
+                return await Task.FromResult(new Radzen.LoadDataArgs() { Skip = 0, Top = PageSize, Filter = searchText });
             }
             else
             {
-                return new Radzen.LoadDataArgs() { Filter = searchText };
+                return await Task.FromResult(new Radzen.LoadDataArgs() { Filter = searchText });
             }
 #else
-            return new Radzen.LoadDataArgs() { Filter = searchText };
+            return await Task.FromResult(new Radzen.LoadDataArgs() { Filter = searchText });
 #endif
         }
 

Radzen.Blazor/NotificationService.cs

@@ -50,17 +50,18 @@ public void Notify(NotificationMessage message)
             }
         }
 
-      /// <summary>
-      /// Notifies the specified severity.
-      /// </summary>
-      /// <param name="severity">The severity.</param>
-      /// <param name="summary">The summary.</param>
-      /// <param name="detail">The detail.</param>
-      /// <param name="duration">The duration.</param>
-      /// <param name="click">The click event.</param>
-      /// <param name="closeOnClick">If true, then the notification will be closed when clicked on.</param>
-      /// <param name="payload">Used to store a custom payload that can be retreived later in the click event handler.</param>
-      public void Notify(NotificationSeverity severity = NotificationSeverity.Info, string summary = "", string detail = "", double duration = 3000, Action<NotificationMessage> click = null, bool closeOnClick = false, object payload = null, Action<NotificationMessage> close = null)
+        /// <summary>
+        /// Notifies the specified severity.
+        /// </summary>
+        /// <param name="severity">The severity.</param>
+        /// <param name="summary">The summary.</param>
+        /// <param name="detail">The detail.</param>
+        /// <param name="duration">The duration.</param>
+        /// <param name="click">The click event.</param>
+        /// <param name="closeOnClick">If true, then the notification will be closed when clicked on.</param>
+        /// <param name="payload">Used to store a custom payload that can be retreived later in the click event handler.</param>
+        /// <param name="close">Action to be executed on close.</param>
+        public void Notify(NotificationSeverity severity = NotificationSeverity.Info, string summary = "", string detail = "", double duration = 3000, Action<NotificationMessage> click = null, bool closeOnClick = false, object payload = null, Action<NotificationMessage> close = null)
         {
             var newMessage = new NotificationMessage()
             {

Radzen.Blazor/PagedDataBoundComponent.cs

@@ -66,7 +66,7 @@ public int PageSize
                 if (_PageSize != value)
                 {
                     _PageSize = value;
-                    OnPageSizeChanged(value);
+                    InvokeAsync(() => OnPageSizeChanged(value));
                 }
             }
         }

Radzen.Blazor/Radzen.Blazor.csproj

@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.Razor">
   <PropertyGroup>
-    <NoWarn>BL9993;BL0007;BL0005</NoWarn>
+	 <NoWarn>BL0007</NoWarn>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <TargetFrameworks>netstandard2.1;net5.0;net6.0;net7.0</TargetFrameworks>
     <RazorLangVersion>3.0</RazorLangVersion>
     <LangVersion>7.3</LangVersion>

Radzen.Blazor/RadzenDataFilterProperty.cs

@@ -177,7 +177,6 @@ public Type FilterPropertyType
 
         object filterValue;
         FilterOperator? filterOperator;
-        LogicalFilterOperator? logicalFilterOperator;
 
         /// <summary>
         /// Set parameters as an asynchronous operation.

Radzen.Blazor/RadzenDataGrid.razor

@@ -274,15 +274,15 @@
                                                                 <RadzenDataGridFilterMenu Grid="@this" Column="@column" />
                                                                 <RadzenDatePicker Disabled=@column.CanSetFilterValue() TValue="@object" Style="width:100%" AllowInput=@(AllowFilterDateInput) AllowClear="true"
                                                       ShowTime="false" ShowTimeOkButton="false" DateFormat="@getFilterDateFormat(column)"
-                                                      Value="@column.GetFilterValue()" Change="@(args => { if(!args.HasValue) { ClearFilter(column, true); } else {column.SetFilterValue(args.Value); ApplyFilter(column, true);} })" />
+                                                      Value="@column.GetFilterValue()" Change="@(args => { if(!args.HasValue) { InvokeAsync(() => ClearFilter(column, true)); } else {column.SetFilterValue(args.Value); InvokeAsync(() => ApplyFilter(column, true));} })" />
                                                             }
                                                         }
                                                         else if (PropertyAccess.IsNullableEnum(column.FilterPropertyType) || PropertyAccess.IsEnum(column.FilterPropertyType))
                                                         {
                                                             <RadzenDropDown Style="width:100%" AllowClear="true" AllowFiltering="false" TValue="@object"
                                                     Value=@column.GetFilterValue() Multiple="false" Placeholder="@EnumFilterSelectText" TextProperty="Text" ValueProperty="Value"
                                                                             Data=@((PropertyAccess.IsNullableEnum(column.FilterPropertyType) ? new object[]{ new { Value = -1, Text = EnumNullFilterText}} : Enumerable.Empty<object>()).Concat(EnumExtensions.EnumAsKeyValuePair(Nullable.GetUnderlyingType(column.FilterPropertyType) ?? column.FilterPropertyType)))
-                                                    Change="@(args => {column.SetFilterValue(args);column.SetFilterOperator(object.Equals(args, -1) ? FilterOperator.IsNull : FilterOperator.Equals);ApplyFilter(column, true);})" />
+                                                    Change="@(args => {column.SetFilterValue(args);column.SetFilterOperator(object.Equals(args, -1) ? FilterOperator.IsNull : FilterOperator.Equals);InvokeAsync(() => ApplyFilter(column, true));})" />
                                                         }
                                                         else if (PropertyAccess.IsNumeric(column.FilterPropertyType))
                                                         {

Radzen.Blazor/RadzenDataGrid.razor.cs

@@ -97,12 +97,12 @@ public Microsoft.AspNetCore.Components.Web.Virtualization.Virtualize<TItem> Virt
             var query = view.AsQueryable().OrderBy(string.Join(',', Groups.Select(g => $"np({g.Property})")));
             _groupedPagedView = query.GroupByMany(Groups.Select(g => $"np({g.Property})").ToArray()).ToList();
 
-            var totalItemsCount = _groupedPagedView.Count();
+            var totalItemsCount = await Task.FromResult(_groupedPagedView.Count());
 
             return new Microsoft.AspNetCore.Components.Web.Virtualization.ItemsProviderResult<GroupResult>(_groupedPagedView.Skip(request.StartIndex).Take(top), totalItemsCount);
         }
 #endif
-       
+
         RenderFragment DrawRows(IList<RadzenDataGridColumn<TItem>> visibleColumns)
         {
             return new RenderFragment(builder =>
@@ -326,7 +326,7 @@ async Task DebounceFilter(RadzenDataGridColumn<TItem> column)
             var inputValue = await JSRuntime.InvokeAsync<string>("Radzen.getInputValue", getFilterInputId(column));
             if (!object.Equals(column.GetFilterValue(), inputValue))
             {
-                await InvokeAsync(() => { OnFilter(new ChangeEventArgs() { Value = inputValue }, column); });
+                await OnFilter(new ChangeEventArgs() { Value = inputValue }, column);
             }
         }
 
@@ -450,7 +450,10 @@ internal void UpdatePickableColumn(RadzenDataGridColumn<TItem> column, bool visi
             selectedColumns = columnsList;
         }
 
-		public void UpdatePickableColumns()
+        /// <summary>
+        /// Updates pickable columns.
+        /// </summary>
+        public void UpdatePickableColumns()
 		{
 			if (allColumns.Any(c => c.Pickable))
 			{
@@ -539,7 +542,7 @@ internal RenderFragment DrawNumericFilter(RadzenDataGridColumn<TItem> column, bo
                 Action<object> action;
                 if (force)
                 {
-                    action = args => OnFilter(new ChangeEventArgs() { Value = args }, column, isFirst);
+                    action = args => InvokeAsync(() => OnFilter(new ChangeEventArgs() { Value = args }, column, isFirst));
                 }
                 else
                 {

Radzen.Blazor/RadzenDataGridColumn.razor.cs

@@ -159,6 +159,9 @@ protected override void OnInitialized()
         [Parameter]
         public int? OrderIndex { get; set; }
 
+        /// <summary>
+        /// Gets the order index.
+        /// </summary>
         public int? GetOrderIndex()
         {
             return orderIndex ?? OrderIndex;
@@ -1020,7 +1023,7 @@ public void SetWidth(string value)
 
             if (IsFrozen())
             {
-                Grid.ChangeState();
+                InvokeAsync(() => Grid.ChangeState());
             }
         }
 

Radzen.Blazor/RadzenDataGridGroupRow.razor

@@ -93,7 +93,7 @@
              var columnsOfGrid = Columns
                    .Where(c => c.GetVisible())
                    .ToList();
-            return columnsOfGrid.Sum(c => CountVisibleLeafColumns(c));
+            return columnsOfGrid.Sum(c => CountVisibleLeafColumns<TItem>(c));
             }
         }
 
@@ -177,7 +177,7 @@
             return i;
         }
 
-    private int CountVisibleLeafColumns<TItem>(RadzenDataGridColumn<TItem> column)
+    private int CountVisibleLeafColumns<T>(RadzenDataGridColumn<TItem> column)
     {
         if (column.ColumnsCollection?.Count == 0)
         {
@@ -187,7 +187,7 @@
         int count = 0;
         foreach (var childColumn in column.ColumnsCollection)
         {
-            count += CountVisibleLeafColumns(childColumn);
+            count += CountVisibleLeafColumns<T>(childColumn);
         }
         return count;
     }

Radzen.Blazor/RadzenDataGridHeaderCell.razor

@@ -91,7 +91,7 @@
                                 }
                                 else if (Column.FilterPropertyType == typeof(bool) || Column.FilterPropertyType == typeof(bool?))
                                 {
-                                    <RadzenCheckBox TriState="true" TValue="@object" Value="@Column.GetFilterValue()" Change="@(args => { Column.FilterValue = null; Column.SetFilterValue(args); Grid.SaveSettings(); Grid.Reload(); })" />
+                                    <RadzenCheckBox TriState="true" TValue="@object" Value="@Column.GetFilterValue()" Change="@(args => { Column.SetFilterValue(null); Column.SetFilterValue(args); Grid.SaveSettings(); InvokeAsync(() => Grid.Reload()); })" />
                                 }
                                 else
                                 {

Radzen.Blazor/RadzenDataGridRow.razor.cs

@@ -1,5 +1,8 @@
 namespace Radzen.Blazor
 {
+    /// <summary>
+    /// RadzenDataGridRow.
+    /// </summary>
     public partial class RadzenDataGridRow<TItem>
     {
     }

Radzen.Blazor/RadzenDatePicker.razor.cs

@@ -501,7 +501,7 @@ protected async Task ParseDate()
 
             if (valid && !DateAttributes(value).Disabled)
             {
-                newValue = TimeOnly && CurrentDate != null ? new DateTime(CurrentDate.Year, CurrentDate.Month, CurrentDate.Day, value.Hour, value.Minute, value.Second) : value;
+                newValue = TimeOnly && CurrentDate != default(DateTime) ? new DateTime(CurrentDate.Year, CurrentDate.Month, CurrentDate.Day, value.Hour, value.Minute, value.Second) : value;
             }
             else
             {

Radzen.Blazor/RadzenDropDownDataGrid.razor

@@ -114,7 +114,7 @@
                 @if (AllowFiltering)
                 {
                     <div class="rz-lookup-search">
-                        <input class="rz-lookup-search-input" id="@SearchID" @ref="@search" tabindex="-1" placeholder="@SearchText"
+                        <input class="rz-lookup-search-input" id="@SearchID" @ref="@search" tabindex="-1" placeholder="@SearchTextPlaceholder"
                                @onchange="@((args) => OnFilter(args))" @onkeydown="@((args) => OnFilterKeyPress(args))" value="@searchText" style="@(ShowSearch ? "" : "margin-right:0px;")"
                                @oninput=@(args => searchText = $"{args.Value}")/>
                         @if (ShowSearch)

Radzen.Blazor/RadzenDropDownDataGrid.razor.cs

@@ -216,7 +216,7 @@ protected override async System.Threading.Tasks.Task OpenPopup(string key = "Arr
         /// </summary>
         /// <value>The search input placeholder text.</value>
         [Parameter]
-        public string SearchText { get; set; } = "Search...";
+        public string SearchTextPlaceholder { get; set; } = "Search...";
 
         /// <summary>
         /// Gets or sets the selected value.

Radzen.Blazor/RadzenGrid.razor.cs

@@ -1,5 +1,8 @@
 namespace Radzen.Blazor
 {
+    /// <summary>
+    /// RadzenGrid.
+    /// </summary>
     public partial class RadzenGrid<TItem>
     {
     }

Radzen.Blazor/RadzenHtmlEditorSource.razor

@@ -18,5 +18,7 @@
         {
             Editor.SetMode(HtmlEditorMode.Design);
         }
+
+        await Task.CompletedTask;
     }
 }

Radzen.Blazor/RadzenPieSeries.razor.cs

@@ -94,7 +94,7 @@ public override string Color
         }
 
         /// <summary>
-        /// Stores <see cref="Data" /> filtered to items greater than zero as an IList of <typeparamref name="TItem"/>.
+        /// Stores Data filtered to items greater than zero as an IList of <typeparamref name="TItem"/>.
         /// </summary>
         /// <value>The items.</value>
         protected IList<TItem> PositiveItems { get; set; }

Radzen.Blazor/RadzenProgressBarCircular.razor.cs

@@ -37,6 +37,9 @@ protected override string GetComponentCssClass()
             return string.Join(" ", classList);
         }
 
+        /// <summary>
+        /// Gets the circle size.
+        /// </summary>
         protected string GetCircleSize()
         {
             switch (Size)

Radzen.Blazor/RadzenScheduler.razor.cs

@@ -223,6 +223,9 @@ public partial class RadzenScheduler<TItem> : RadzenComponent, IScheduler
 
         IList<ISchedulerView> Views { get; set; } = new List<ISchedulerView>();
 
+        /// <summary>
+        /// Gets the SelectedView.
+        /// </summary>
         public ISchedulerView SelectedView
         {
             get

Radzen.Blazor/RadzenTimeline.razor.cs

@@ -27,6 +27,10 @@ namespace Radzen.Blazor
     /// </example>
     public partial class RadzenTimeline : RadzenComponent
     {
+        /// <summary>
+        /// Gets or sets the items.
+        /// </summary>
+        /// <value>The items.</value>
         [Parameter]
         public RenderFragment Items { get; set; }
 

Radzen.Blazor/RadzenTimelineItem.razor.cs

@@ -27,6 +27,9 @@ public partial class RadzenTimelineItem : RadzenComponent
         [Parameter]
         public RenderFragment ChildContent { get; set; }
 
+        /// <summary>
+        /// Gets or sets the text.
+        /// </summary>
         [Parameter]
         public string Text { get; set; }
 
@@ -36,6 +39,9 @@ public partial class RadzenTimelineItem : RadzenComponent
         [Parameter]
         public RenderFragment LabelContent { get; set; }
 
+        /// <summary>
+        /// Gets or sets the label.
+        /// </summary>
         [Parameter]
         public string Label { get; set; }
 
@@ -64,7 +70,7 @@ public partial class RadzenTimelineItem : RadzenComponent
         public Variant PointVariant { get; set; } = Variant.Filled;
 
         /// <summary>
-        /// Specifies the Shadow level from <c>0</c> (no shadow) to <c>10<c>. Set to <c>1</c> by default.
+        /// Specifies the Shadow level from <c>0</c> (no shadow) to <c>10</c>. Set to <c>1</c> by default.
         /// </summary>
         [Parameter]
         public int PointShadow { get; set; } = 1;

Radzen.Blazor/RadzenTreeItem.razor.cs

@@ -13,6 +13,10 @@ namespace Radzen.Blazor
     /// </summary>
     public partial class RadzenTreeItem : IDisposable
     {
+        /// <summary>
+        /// Specifies additional custom attributes that will be rendered by the component.
+        /// </summary>
+        /// <value>The attributes.</value>
         [Parameter(CaptureUnmatchedValues = true)]
         public IReadOnlyDictionary<string, object> Attributes { get; set; }
 

Radzen.Blazor/RadzenYearView.razor.cs

@@ -31,7 +31,7 @@ public override string Title
         public override string Text { get; set; } = "Year";
 
         /// <summary>
-        /// Specifies the text displayed when there are more appointments in a slot than <see cref="MaxAppointmentsInSlot" />.
+        /// Specifies the text displayed when there are more appointments in a slot than MaxAppointmentsInSlot.
         /// </summary>
         /// <value>The more text. Set to <c>"+ {0} more"</c> by default.</value>
         [Parameter]