Apply suggestions from code review

radxa-pkg · Jan 8, 2024 · 819f069 · 819f069
1 parent ee2eb26
commit 819f069
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/usr/lib/rsetup/cli/u-boot-menu.sh b/src/usr/lib/rsetup/cli/u-boot-menu.sh
@@ -13,7 +13,7 @@ check_overlay_conflict_init() {
 check_overlay_conflict() {
     local name resources res i
     mapfile -t resources < <(parse_dtbo "exclusive" "$1")
-    mapfile -t name < <(parse_dtbo "--default-value" "file" "title" "$1")
+    mapfile -t name < <(parse_dtbo --default-value "file" "title" "$1")
 
     for res in "${resources[@]}"
     do

diff --git a/src/usr/lib/rsetup/tui/overlay/overlay.sh b/src/usr/lib/rsetup/tui/overlay/overlay.sh
@@ -81,7 +81,7 @@ __overlay_show() {
     # Bash doesn support IFS=$'\0'
     # Use array to emulate this
     local items=()
-    mapfile -t items < <(parse_dtbo "--show-overlays" "title" "${dtbos[@]}")
+    mapfile -t items < <(parse_dtbo --show-overlays "title" "${dtbos[@]}")
     while (( ${#items[@]} >= 3 ))
     do
         checklist_add "${items[0]/$'\n'}" "${items[1]/$'\n'}" "${items[2]/$'\n'}"
@@ -116,7 +116,7 @@ __overlay_validate() {
         fi
 
         local title package
-        mapfile -t title < <(parse_dtbo "--default-value" "file"  "title" "$U_BOOT_FDT_OVERLAYS_DIR/$item"*)
+        mapfile -t title < <(parse_dtbo --default-value "file"  "title" "$U_BOOT_FDT_OVERLAYS_DIR/$item"*)
         mapfile -t package < <(parse_dtbo "package" "$U_BOOT_FDT_OVERLAYS_DIR/$item"*)
         if [[ "${package[0]}" != "null" ]]
         then