Skip to content

Commit

Permalink
macos workflow, format build for windows, fix config_file.c called pt…
Browse files Browse the repository at this point in the history
…hread directly
  • Loading branch information
radkesvat committed Jun 10, 2024
1 parent c381bcb commit a484ba0
Show file tree
Hide file tree
Showing 3 changed files with 62 additions and 1 deletion.
58 changes: 58 additions & 0 deletions .github/workflows/cmake-multi-macos.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
name: macos gcc + clang

on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]


jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false


matrix:
os: [macos-latest]
build_type: [Release]
c_compiler: [gcc, clang]
include:
- os: macos-latest
c_compiler: gcc
cpp_compiler: g++
- os: macos-latest
c_compiler: clang
cpp_compiler: clang++


steps:
- uses: actions/checkout@v3


- name: Set reusable strings

id: strings
shell: bash
run: |
echo "build-output-dir=${{ github.workspace }}/build" >> "$GITHUB_OUTPUT"
- name: Install dependencies on macOS
if: runner.os == 'macOS'
run: |
brew update
brew install ccache
- name: Configure CMake
run: >
cmake -B ${{ steps.strings.outputs.build-output-dir }}
-DCMAKE_CXX_COMPILER=${{ matrix.cpp_compiler }}
-DCMAKE_C_COMPILER=${{ matrix.c_compiler }}
-DCMAKE_BUILD_TYPE=${{ matrix.build_type }}
-S ${{ github.workspace }}
- name: Build
run: cmake --build ${{ steps.strings.outputs.build-output-dir }}


3 changes: 3 additions & 0 deletions ww/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ endif()

if(CMAKE_BUILD_TYPE STREQUAL "Release")
target_link_options(ww PUBLIC -s)
if (WIN32)
target_link_options(ww PUBLIC -static-libgcc -static)
endif()
endif()

# target_compile_options(hv_static PRIVATE -fPIC)
Expand Down
2 changes: 1 addition & 1 deletion ww/config_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ void commitChangesSoft(config_file_t *state)
#ifdef OS_WIN
commitChangesHard(state);
#else
if (0 == pthread_mutex_trylock(&(state->guard)))
if (0 == hmutex_lock(&(state->guard)))
{
unsafeCommitChanges(state);
releaseUpdateLock(state);
Expand Down

0 comments on commit a484ba0

Please sign in to comment.