Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: linting and cleanup #68

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

hairmare
Copy link
Member

@hairmare hairmare commented Jan 31, 2022

This is a first step towards #69 (haha nice 😏).

A lot of it is faffing about with basics like pylint.

It's the start of some more proactive maintaining of suisa_sendemeldung and also aligning it with the foundational stuff i've done in nowplaying et al. over the last few weeks/months.

@hairmare hairmare force-pushed the chore/linting-and-cleanup branch from 8b4632c to e5e0ef4 Compare January 31, 2022 20:57
@hairmare hairmare mentioned this pull request Jan 31, 2022
11 tasks
@hairmare hairmare force-pushed the chore/linting-and-cleanup branch 4 times, most recently from 0a868cd to 5899c25 Compare January 31, 2022 21:12
@hairmare hairmare force-pushed the chore/linting-and-cleanup branch from 5899c25 to 979785c Compare January 31, 2022 21:16
@hairmare hairmare marked this pull request as ready for review January 31, 2022 21:19
@hairmare
Copy link
Member Author

hairmare commented Jan 31, 2022

@spameier lemme know if this is ok, i have some more changes in the works for suisa_sendemeldung but it's gonna be a slow evolution given how rarely this thing runs in prod.

Copy link
Member

@spameier spameier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort! Lookgs good to me except the EditorConfig thingy.

.vscode/settings.json Outdated Show resolved Hide resolved
For this to work with VS Code users need to install the editorconfig.editorconfig extension
@hairmare hairmare requested a review from spameier February 4, 2022 12:53
@spameier spameier merged commit 43eb483 into radiorabe:master Feb 7, 2022
@hairmare hairmare deleted the chore/linting-and-cleanup branch June 25, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants