fix: use rabe base image and wheel multistage build #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairmare
force-pushed
the
chore/use-rabe-base-images
branch
from
ef0f774
to
6890930
Compare
spameier
reviewed
Oct 21, 2022
|
Sorry for the late reply, I like the idea. Will dependabot update to newer tags when new versions of |
|
i updated this to also cover basic, fails to build type errors in ci let's get it merged this month :) |
|
Dec go brrrrrrt imma be available should this fail |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses radiorabe/python-minimal as the runtime image and radiorabe/s2i-python for building the app.
The new build process first builds a wheel in a first build stage and then installs this wheel into the final app container.
Switching to a RaBe base image helps us with lifecycle management since there is now one entrypoint of new base image versions for all of our python properties. Additionally the shared base image makes pulling this faster run on a shared container host since the base layers will most likely already be there.