Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency golangci/golangci-lint to v1.56.2 #187

Merged
merged 2 commits into from
Mar 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.golang.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ jobs:
- uses: golangci/golangci-lint-action@3cfe3a4abbb849e10058ce4af15d205b6da42804 # v4.0.0
with:
# renovate: datasource=github-releases depName=golangci/golangci-lint
version: v1.54.2
version: v1.56.2
27 changes: 14 additions & 13 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,25 @@ run:
linters:
enable-all: true
disable:
- exhaustruct # Find structs that have uninitialized fields. => We want to rely on default field initialization
- deadcode # Disable because they are deprecated and throw warning in logs
- depguard # We do not have particular restrictions on which packages should be allowed or not
- dupl # Disable because they are deprecated and throw warning in logs
- exhaustive # We don't want to force struct exhaustive
- exhaustivestruct # Disable because they are deprecated and throw warning in logs
- exhaustruct # Find structs that have uninitialized fields. => We want to rely on default field initialization
- funlen # checks for long functions => legit, but we prefer to use sonarqube and be non-blocking
- gochecknoglobals # Check that no globals are present in Go code. => We want to use global variables in some situations
- goerr113 # check the errors handling expressions => Is a little extreme
- golint # Disable because they are deprecated and throw warning in logs
- gomnd # Magic number detector for Go. => We don't care
- nlreturn # Checks for a new line before return and branch statements. => We don't care
- tagliatelle # A linter that handles struct tags. => Too many false positive errors
- wsl # Whitespace Linter - Forces you to use empty lines! => We don't care
- exhaustive # We don't want to force struct exhaustive
- maligned # Disable because they are deprecated and throw warning in logs
- ifshort # Disable because they are deprecated and throw warning in logs
- interfacer # Disable because they are deprecated and throw warning in logs
- maligned # Disable because they are deprecated and throw warning in logs
- nlreturn # Checks for a new line before return and branch statements. => We don't care
- nosnakecase # Disable because they are deprecated and throw warning in logs
- perfsprint # We prefer lisibility over performance
- scopelint # Disable because they are deprecated and throw warning in logs
- golint # Disable because they are deprecated and throw warning in logs
- exhaustivestruct # Disable because they are deprecated and throw warning in logs
- ifshort # Disable because they are deprecated and throw warning in logs
- dupl # Disable because they are deprecated and throw warning in logs
- deadcode # Disable because they are deprecated and throw warning in logs
- varcheck # Disable because they are deprecated and throw warning in logs
- structcheck # Disable because they are deprecated and throw warning in logs
- nosnakecase # Disable because they are deprecated and throw warning in logs
- tagliatelle # A linter that handles struct tags. => Too many false positive errors
- varcheck # Disable because they are deprecated and throw warning in logs
- wsl # Whitespace Linter - Forces you to use empty lines! => We don't care
2 changes: 1 addition & 1 deletion pkg/http/middlewares_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ func TestNewRecoverMiddleware(t *testing.T) {
zap.InfoLevel,
))

next := http.HandlerFunc(func(writer http.ResponseWriter, _ *http.Request) { panic("STONK !!!") })
next := http.HandlerFunc(func(_ http.ResponseWriter, _ *http.Request) { panic("STONK !!!") })
mw := gcpehttp.NewRecoverMiddleware(logger)

req, _ := http.NewRequestWithContext(context.Background(), http.MethodPost, "https://:::0", nil)
Expand Down
Loading