feat: add latest current and reference job status to modelout #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/ROS-310-add-latest-current-and-reference-job-status-to-modelout # Conflicts: # api/app/models/model_dto.py
… into feature/ROS-310-add-latest-current-and-reference-job-status-to-modelout
… into feature/ROS-310-add-latest-current-and-reference-job-status-to-modelout
rivamarco
reviewed
Jul 2, 2024
| @@ -68,7 +68,5 @@ class ModelDefinition(BaseModelDefinition): | |||
| uuid: uuid_lib.UUID = Field(default_factory=lambda: uuid_lib.uuid4()) | |||
| created_at: str = Field(alias='createdAt') | |||
| updated_at: str = Field(alias='updatedAt') | |||
There was a problem hiding this comment.
Why we have alias if we have the generator to_camel?
rivamarco
approved these changes
Jul 2, 2024
Comment on lines
+202
to
+211
| latest_reference_job_status = ( | ||
| latest_reference_dataset.status | ||
| if latest_reference_dataset | ||
| else JobStatus.MISSING_REFERENCE | ||
| ) | ||
| latest_current_job_status = ( | ||
| latest_current_dataset.status | ||
| if latest_current_dataset | ||
| else JobStatus.MISSING_CURRENT | ||
| ) |
There was a problem hiding this comment.
Just a question: why do we need different JobStatus for current and reference? Why not just MISSING for both?
There was a problem hiding this comment.
you raise a fair point. We had opted to set it up dual status with the FE guys, but it could be planned to be unified in a later step if it's okay with them
lorenzodagostinoradicalbit
approved these changes
Jul 2, 2024
dtria91
deleted the
feature/ROS-310-add-latest-current-and-reference-job-status-to-modelout
branch
maocorte
pushed a commit
that referenced
this pull request
Jul 16, 2024
* feat: add latest current and reference job status to modelOut * fix: align with main * fix: remove unused model definition fields into the sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add latest current and reference job status to ModelOut
remove unused model definition fields from sdk