Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): added ability to set S3 endpoint url if needed #34

Merged
merged 1 commit into from
Jun 25, 2024
Merged

feat(sdk): added ability to set S3 endpoint url if needed #34

merged 1 commit into from
Jun 25, 2024

Conversation

maocorte
Copy link
Member

updated AwsCredentials adding endpoint_url property in order to be able to change it in case of other S3 compatible solutions

@maocorte maocorte requested review from rivamarco and dtria91 June 25, 2024 15:15
@maocorte maocorte merged commit c6a8f14 into main Jun 25, 2024
5 checks passed
@maocorte maocorte deleted the sdk_add_aws_endpoint_url branch June 25, 2024 15:58
@devops-radicalbit devops-radicalbit mentioned this pull request Jun 25, 2024
Merged
@devops-radicalbit devops-radicalbit mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rivamarco rivamarco rivamarco approved these changes

@dtria91 dtria91 Awaiting requested review from dtria91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maocorte @rivamarco