Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added architecture section #156

Merged
merged 8 commits into from
Aug 5, 2024
Merged

docs: added architecture section #156

merged 8 commits into from
Aug 5, 2024

Conversation

maocorte
Copy link
Member

@maocorte maocorte commented Aug 5, 2024

  • added a minimal architecture section inside documentation
  • changed files/menu hierarchy using sidebar_position instead of file names

## API

API is the core of the platform, it exposes all the functionalities via REST APIs.
It require a PostgreSQL database to store data and a Kubernetes cluster to run Spark jobs for metrics evaluations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maocorte there's a typo.
Errata: It require;
Corrig: It requires

# Architecture

In this section we'll explore the architecture of the Radicalbit AI platform.
The image below show all the components of the platform:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maocorte there's a typo.
Errata: The image below show;
Corrige: The image below shows


API is the core of the platform, it exposes all the functionalities via REST APIs.
It require a PostgreSQL database to store data and a Kubernetes cluster to run Spark jobs for metrics evaluations.
To store all dataset files a distributes storage is used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maocorte there's a typo.
Errata: distributes;
Corrige: distributed

## UI

To use REST APIs with a human friendly interface, a UI is provided.
It covers all the implemented APIs, starting from models creation ending with all metrics visualization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maocorte
I suggest adding an "and": " starting from models creation AND ending with all metrics visualization"

## SDK

To interact with API programmatically, a Python SDK is provided.
SDK implements all functionalities exposed via REST API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maocorte
I suggest adding a "The" at the beginning of the sentence: "The SDK implements all..."

@aleconf aleconf requested a review from mmariniello90 August 5, 2024 08:07
Copy link
Member

@aleconf aleconf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked for three changes in the docs/docs/architecture.md file. Save for that it looks good to me.


# Architecture

In this section we'll explore the architecture of the Radicalbit AI platform.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maocorte Remove «'ll».

## UI

To use REST APIs with a human friendly interface, a UI is provided.
It covers all the implemented APIs, starting from models creation and ending with all metrics visualization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maocorte «model creation», not «models creation».


## SDK

To interact with API programmatically, a Python SDK is provided.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maocorte Write Python SDK in italics to show it is an entry in the documentation to keep it consistent with other files.

@aleconf aleconf self-requested a review August 5, 2024 09:09
@maocorte maocorte merged commit f3df086 into main Aug 5, 2024
5 checks passed
@maocorte maocorte deleted the docs_add_solution_arch branch August 5, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants