feat: add regression line to residuals metric (#111)

radicalbit · Jul 16, 2024 · c2f5437 · c2f5437
1 parent c5511ed
commit c2f5437
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 4 deletions.
diff --git a/api/app/models/metrics/model_quality_dto.py b/api/app/models/metrics/model_quality_dto.py
@@ -144,6 +144,7 @@ class ResidualsMetrics(BaseModel):
     standardized_residuals: List[float]
     predictions: List[float]
     targets: List[float]
+    regression_line: List[List[float]]
 
     model_config = ConfigDict(populate_by_name=True, alias_generator=to_camel)
 

diff --git a/api/tests/commons/db_mock.py b/api/tests/commons/db_mock.py
@@ -337,6 +337,7 @@ def get_sample_current_dataset(
         'standardized_residuals': [0.02, 0.03],
         'targets': [1, 2.2, 3],
         'predictions': [1.3, 2, 4.5],
+        'regression_line': [[1.2, 0.3], [1.4, 2.3]],
     },
 }
 

diff --git a/init-data/init_db.sql b/init-data/init_db.sql
diff --git a/sdk/radicalbit_platform_sdk/models/dataset_model_quality.py b/sdk/radicalbit_platform_sdk/models/dataset_model_quality.py
@@ -143,6 +143,7 @@ class ResidualsMetrics(BaseModel):
     standardized_residuals: List[float]
     predictions: List[float]
     targets: List[float]
+    regression_line: List[List[float]]
 
     model_config = ConfigDict(populate_by_name=True, alias_generator=to_camel)
 

diff --git a/sdk/tests/apis/model_current_dataset_test.py b/sdk/tests/apis/model_current_dataset_test.py
@@ -1002,7 +1002,8 @@ def test_regression_model_quality_ok(self):
                                 "correlationCoefficient": {correlation_coefficient},
                                 "standardizedResiduals": [0.02, 0.03],
                                 "targets": [1, 2.2, 3],
-                                "predictions": [1.3, 2, 4.5]
+                                "predictions": [1.3, 2, 4.5],
+                                "regression_line": [[1.2, 0.3], [1.4, 2.3]]
                             }}
                         }},
                         "grouped_metrics": {{

diff --git a/sdk/tests/apis/model_reference_dataset_test.py b/sdk/tests/apis/model_reference_dataset_test.py
@@ -391,7 +391,8 @@ def test_regression_model_metrics_ok(self):
                             "correlationCoefficient": {correlation_coefficient},
                             "standardizedResiduals": [0.02, 0.03],
                             "targets": [1, 2.2, 3],
-                            "predictions": [1.3, 2, 4.5]
+                            "predictions": [1.3, 2, 4.5],
+                            "regression_line": [[1.2, 0.3], [1.4, 2.3]]
                         }}
                     }}
                 }}""",